refactor(useButtonType): simplify and some related docs

[dyc3]

Summary

Some trivially minor changes to the rule and related docs. Planning to make a bug fix in a follow up PR, and I don't want these changes to clog up that PR.

No changeset because the rule hasn't been released yet, and its purely a refactor.

Test Plan

snapshots changed only because of adjusted whitespace in the diagnostic.

Docs

[changeset-bot]

⚠️ No Changeset found

Latest commit: f36549b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

Refactors the diagnostic construction in crates/biome_html_analyze/src/lint/a11y/use_button_type.rs to inline the range and conditional message logic (removing intermediate span/message variables). Adds find_attribute_by_name(&self, name_to_lookup: &str) -> Option<HtmlAttribute> to AnyHtmlElement in crates/biome_html_syntax/src/element_ext.rs, performing a case-insensitive attribute lookup across HtmlElement and HtmlSelfClosingElement variants and returning None for variants without attributes.

Possibly related PRs

• fix(biome_html_analyze): consolidate a11y helpers and fix aria-hidden behavior #8837: Overlaps with this PR’s addition of AnyHtmlElement::find_attribute_by_name and related a11y helper refactoring that consumes it.
• feat(biome_html_analyze): add useButtonType rule (#8241) #8243: Touches the same use_button_type.rs lint and contains earlier changes to that rule which are directly relevant.

Suggested reviewers

• ematipico
• Netail

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main refactoring work—simplifying the useButtonType diagnostic construction and adjusting related documentation.
Description check	✅ Passed	The description clearly explains the motivation (trivial refactoring changes to keep a follow-up bug fix PR clean) and context (no changeset needed), relating directly to the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch dyc3/use-button-type-tweaks

---

No actionable comments were generated in the recent review. 🎉

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will degrade performance by 8.03%

_{Comparing dyc3/use-button-type-tweaks (f36549b) with next (b5dd9ce)}

Summary

❌ 2 regressed benchmarks
✅ 1 untouched benchmark
🆕 1 new benchmark
⏩ 152 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	BASE	HEAD	Efficiency
🆕	html_analyzer[index_1033418810622582172.html]	N/A	411.1 µs	N/A
❌	index_1033418810622582172.html[uncached]	118.2 µs	128.5 µs	-8.03%
❌	index_1033418810622582172.html[cached]	102 µs	110.5 µs	-7.67%

Footnotes

1. 152 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩