Conversation
🦋 Changeset detectedLatest commit: e96b2f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
e8501bb to
fc3e73f
Compare
WalkthroughThis PR introduces an ignore configuration option to the Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist. Comment |
crates/biome_js_analyze/tests/specs/correctness/useHookAtTopLevel/valid-ignoreOption.js.snap
Show resolved
Hide resolved
crates/biome_js_analyze/tests/specs/correctness/useHookAtTopLevel/ignoreOption.js.snap
Outdated
Show resolved
Hide resolved
fc3e73f to
e96b2f5
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@crates/biome_js_analyze/tests/specs/correctness/useHookAtTopLevel/invalid-ignoreOption.js`:
- Around line 1-9: The test file declares it should generate diagnostics but
contains Component3 which calls useIgnoredHook (an ignored hook), so it won't
produce a diagnostic and duplicates the valid-ignoreOption test; either remove
the Component3 function block (lines defining function Component3 and its body)
from this invalid file, or change the hook call to a non-ignored hook name
(e.g., replace useIgnoredHook with a non-ignored symbol like useFooHook) so that
Component3 actually triggers the intended diagnostic; locate the Component3
function and update or delete it accordingly.
| /* should generate diagnostics */ | ||
|
|
||
| // Valid: ignored hook after early return | ||
| function Component3({ a }) { | ||
| if (a != 1) { | ||
| return; | ||
| } | ||
| useIgnoredHook(); | ||
| } |
There was a problem hiding this comment.
Test case mismatch: Component3 shouldn't be in the invalid file.
The file header states "should generate diagnostics", but Component3 uses useIgnoredHook which is in the ignore list—so it won't produce a diagnostic. This appears to be a duplicate of the same test in valid-ignoreOption.js.
Consider removing lines 3-9, or if you intended to test something different here, update the hook name to a non-ignored one.
🤖 Prompt for AI Agents
In
`@crates/biome_js_analyze/tests/specs/correctness/useHookAtTopLevel/invalid-ignoreOption.js`
around lines 1 - 9, The test file declares it should generate diagnostics but
contains Component3 which calls useIgnoredHook (an ignored hook), so it won't
produce a diagnostic and duplicates the valid-ignoreOption test; either remove
the Component3 function block (lines defining function Component3 and its body)
from this invalid file, or change the hook call to a non-ignored hook name
(e.g., replace useIgnoredHook with a non-ignored symbol like useFooHook) so that
Component3 actually triggers the intended diagnostic; locate the Component3
function and update or delete it accordingly.
Summary
requested here: #7097 (comment)
Test Plan
snapshots
Docs