fix(lint): revamp the noGlobalDirnameFilename rule to catch many false negatives

[siketyan]

Summary

Fixes #8829

The rule will now use JsReferenceIdentifier node to query all usages of __dirname and __filename in many locations.

Test Plan

Added snapshot tests from the issue.

Docs

N/A

[changeset-bot]

🦋 Changeset detected

Latest commit: 5270d7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Walkthrough

Refactors the noGlobalDirnameFilename lint rule to reduce false negatives. The implementation shifts from multi-variant node analysis to a single-path approach querying JsReferenceIdentifier directly. The rule now delegates identifier replacement logic to parent-struct checks (JsIdentifierExpression and JsShorthandPropertyObjectMember) and simplifies binding detection. A new test file verifies the rule behaves correctly across diverse usage patterns including concatenation, templates, operators, and JSX contexts.

Possibly related PRs

• fix(lint/useExhaustiveDependencies): correctly fix the dependency list from a shorthand object member #7498: Modifies lint rule logic to handle JsReferenceIdentifier nodes with updated query types and casting patterns.
• fix(lint): extend matcher for GritCodeSnippet to cover edge case #7786: Refactors identifier node matching logic by handling JsIdentifier/JsReferenceIdentifier and their wrapper expressions differently.

Suggested labels

A-Linter, L-JavaScript

Suggested reviewers

• ematipico
• dyc3
• arendjr

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately reflects the main change: revamping the noGlobalDirnameFilename rule to catch false negatives by querying JsReferenceIdentifier nodes.
Description check	✅ Passed	The description clearly relates to the changeset, explaining the rule change to use JsReferenceIdentifier and referencing the issue being fixed with added test coverage.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing siketyan:fix/GH-8829 (5270d7a) with main (7c96517)}

Summary

✅ 58 untouched benchmarks
⏩ 95 skipped benchmarks¹

Footnotes

1. 95 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[ematipico]

Great glow up