fix(linter): fix useExhaustiveDependencies false positive with arrow function params

[ddmoney420]

Summary

Fixes false positive in useExhaustiveDependencies rule when props are destructured in function body or accessed directly with arrow function params without parentheses.

Problem

The rule incorrectly flagged hook dependencies as "unnecessary" when:

1. Arrow functions used parameters without parentheses (e.g., props =>)
2. Props were accessed via destructuring in function body (e.g., const { msg } = props)

Example that was incorrectly flagged:

const Component: React.FC<Props> = props => {
  const { msg } = props
  useEffect(() => console.log(msg), [msg]); // ❌ false positive: "msg" is unnecessary
};

Root Cause

The bug was in the is_stable_expression function. It had a "self-reference" check that returned true (stable) when an identifier's ancestors included its declaration node.

For arrow functions with parameters without parentheses (props =>), the binding's declaration is the entire JsArrowFunctionExpression. Since the arrow function is an ancestor of any identifier used inside it, the check incorrectly returned true for parameter usages in the body.

Solution

Modified the self-reference check to exclude arrow function parameters, formal parameters, and rest parameters from being considered "stable self-references":

if is_ancestor
    && !matches!(
        decl,
        AnyJsBindingDeclaration::JsArrowFunctionExpression(_)
            | AnyJsBindingDeclaration::JsFormalParameter(_)
            | AnyJsBindingDeclaration::JsRestParameter(_)
    )
{
    return true;
}

Test plan

• Added test case covering all scenarios from the issue
• All existing useExhaustiveDependencies tests pass (53 tests)
• All biome_js_analyze tests pass (1990 tests)

AI Disclosure

This PR was written primarily by Claude Code (AI assistant).

Fixes #8883

🤖 Generated with Claude Code

[changeset-bot]

⚠️ No Changeset found

Latest commit: b6de69d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

This PR fixes false positives in the useExhaustiveDependencies linter rule. The changes refine the is_stable_binding function to check for binding declarations before pattern matching, and update is_stable_expression to accurately determine whether an identifier's declaration is an ancestor of the reference. The logic now treats unknown references as stable rather than potentially unstable. A new test file validates the fix for destructuring in function bodies versus parameters.

Possibly related PRs

• fix(linter): useExhaustiveDependencies properly handles aliased destructured object keys when using stableResult configuration #8529 — Modifies useExhaustiveDependencies binding-resolution logic for destructured and aliased key resolution.
• fix(lint): remove useExhaustiveDependencies spurious errors on dependency-first custom hooks; improve docs #8401 — Modifies the same use_exhaustive_dependencies lint implementation with related stability and dependency-checking logic.
• fix(linter): useExhaustiveDependencies multiple fixes (fixes #3080, fixes #4248, fixes #5914, fixes #8427, fixes #8484, fixes #3685, fixes #3512, fixes #7982) #8767 — Modifies use_exhaustive_dependencies.rs stability logic for is_stable_binding and is_stable_expression behaviour.

Suggested labels

A-Linter, L-JavaScript

Suggested reviewers

• dyc3
• ematipico
• arendjr

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main fix: addressing a false positive in useExhaustiveDependencies when arrow function params lack parentheses.
Description check	✅ Passed	The description clearly explains the problem, root cause, solution, and test coverage—all directly related to the code changes.
Linked Issues check	✅ Passed	The PR directly addresses issue #8883 by fixing the false positive when props are destructured in function body or accessed via arrow function params, and preserves detection of actual missing dependencies.
Out of Scope Changes check	✅ Passed	All changes are scoped to fixing the reported issue: modifications to is_stable_expression logic and an aligned test case for the specific scenarios.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Netail]

I believe this has already been included in #8900

[ematipico]

Thank you @ddmoney420 . We will go with #8900 fix