Skip to content

feat(linter): add e18e rules#8898

Merged
ematipico merged 5 commits intonextfrom
feat/add-e18e-rules
Jan 30, 2026
Merged

feat(linter): add e18e rules#8898
ematipico merged 5 commits intonextfrom
feat/add-e18e-rules

Conversation

@ematipico
Copy link
Member

Summary

Changes were made with Claude Code, they were fairly easy.

Test Plan

CI should stay green

Docs

@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2026

🦋 Changeset detected

Latest commit: 7caf390

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ematipico ematipico requested review from a team January 28, 2026 17:11
@github-actions github-actions bot added A-CLI Area: CLI A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jan 28, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 28, 2026

Walkthrough

Adds RuleSource::EslintE18e(&'static str) and updates Display/namespace/as_rule_name/to_rule_url/variant_index to support the e18e ESLint plugin. Adds a changeset for a patch release. Updates six Biome JS lint rule declarations to include corresponding e18e sources: useAtIndex, useExponentiationOperator, noPrototypeBuiltins, useDateNow, useSpread, and useObjectSpread. Also changes the domain of UseConsistentEnumValueType to RuleDomain::Types and updates a panic message to reference "Types domain." No other control flow or diagnostic behaviour changes.

Possibly related PRs

Suggested labels

A-Core

Suggested reviewers

  • dyc3
  • ematipico
  • siketyan
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarises the main change: adding support for e18e ESLint plugin as a recognised rule source across six lint rules.
Description check ✅ Passed The description is related to the changeset, disclosing AI assistance and setting expectations for testing, though it lacks implementation details.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/add-e18e-rules

Comment @coderabbitai help to get the list of available commands and usage tips.

@dyc3
Copy link
Contributor

dyc3 commented Jan 28, 2026

Sorry, I had forgotten to merge #8864, and this will conflict with it because it changed how RuleSource works significantly. Can you rebase? (its not showing the conflicts because this PR is currently against next, not main)

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 28, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing feat/add-e18e-rules (7caf390) with next (bdd3b6e)

Summary

✅ 58 untouched benchmarks
⏩ 96 skipped benchmarks1

Footnotes

  1. 96 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@ematipico ematipico force-pushed the feat/add-e18e-rules branch from 16686be to 0c3c053 Compare January 28, 2026 19:32
@github-actions github-actions bot added A-Formatter Area: formatter L-CSS Language: CSS labels Jan 29, 2026
@github-actions github-actions bot added the A-Project Area: project label Jan 30, 2026
@ematipico ematipico merged commit 7e48bd4 into next Jan 30, 2026
18 checks passed
@ematipico ematipico deleted the feat/add-e18e-rules branch January 30, 2026 10:46
@github-actions github-actions bot mentioned this pull request Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CLI Area: CLI A-Formatter Area: formatter A-Linter Area: linter A-Project Area: project L-CSS Language: CSS L-JavaScript Language: JavaScript and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants