Skip to content

fix(migrate): fix migrate command not picking up rules for css, graphql, html#8863

Merged
ematipico merged 1 commit intomainfrom
dyc3/migrate-fix-missing-rules
Jan 25, 2026
Merged

fix(migrate): fix migrate command not picking up rules for css, graphql, html#8863
ematipico merged 1 commit intomainfrom
dyc3/migrate-fix-missing-rules

Conversation

@dyc3
Copy link
Contributor

@dyc3 dyc3 commented Jan 25, 2026

Summary

I was working on some improvements to the migrate command, and noticed that HTML rules were not getting migrated. This PR fixes that.

Test Plan

Manually tested on a couple open source codebases.

Docs

@changeset-bot
Copy link

changeset-bot bot commented Jan 25, 2026

🦋 Changeset detected

Latest commit: 9c5238d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

dyc3 commented Jan 25, 2026

@github-actions github-actions bot added A-CLI Area: CLI A-Tooling Area: internal tools labels Jan 25, 2026
@dyc3 dyc3 requested review from a team January 25, 2026 22:25
@dyc3 dyc3 marked this pull request as ready for review January 25, 2026 22:25
@github-actions
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 52832 52832 0
Passed 51614 51614 0
Failed 1176 1176 0
Panics 42 42 0
Coverage 97.69% 97.69% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 38 38 0
Passed 37 37 0
Failed 1 1 0
Panics 0 0 0
Coverage 97.37% 97.37% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6300 6300 0
Passed 2085 2085 0
Failed 4215 4215 0
Panics 0 0 0
Coverage 33.10% 33.10% 0.00%

ts/babel

Test result main count This PR count Difference
Total 626 626 0
Passed 560 560 0
Failed 66 66 0
Panics 0 0 0
Coverage 89.46% 89.46% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18855 18855 0
Passed 14054 14054 0
Failed 4800 4800 0
Panics 1 1 0
Coverage 74.54% 74.54% 0.00%

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 25, 2026

Walkthrough

This patch release addresses ESLint rule detection failures across multiple languages. A changelog entry documents the fix, whilst the core change extends ESLint migration code generation by invoking additional rule registries—specifically for GraphQL, CSS, and HTML analyse modules. This expands the set of rules collected during migration mapping generation, enabling proper detection for these language types.

Suggested labels

A-Linter, L-JavaScript

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarises the main change: fixing the migrate command to pick up CSS, GraphQL, and HTML rules.
Description check ✅ Passed The PR description clearly explains the motivation (HTML rules not being migrated) and the solution, directly relating to the changeset modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@ematipico ematipico merged commit 79386e0 into main Jan 25, 2026
17 checks passed
@ematipico ematipico deleted the dyc3/migrate-fix-missing-rules branch January 25, 2026 23:52
@github-actions github-actions bot mentioned this pull request Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CLI Area: CLI A-Tooling Area: internal tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants