feat(html_parser): add name reference identifier by Netail · Pull Request #8827 · biomejs/biome

Netail · 2026-01-21T22:54:39Z

Summary

Add support for the name of an element being a reference identifier (hopefully into the right direction?)

Test Plan

Docs

changeset-bot · 2026-01-21T22:54:43Z

🦋 Changeset detected

Latest commit: 0befd10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages

Name	Type
@biomejs/biome	Minor
@biomejs/cli-win32-x64	Minor
@biomejs/cli-win32-arm64	Minor
@biomejs/cli-darwin-x64	Minor
@biomejs/cli-darwin-arm64	Minor
@biomejs/cli-linux-x64	Minor
@biomejs/cli-linux-arm64	Minor
@biomejs/cli-linux-x64-musl	Minor
@biomejs/cli-linux-arm64-musl	Minor
@biomejs/wasm-web	Minor
@biomejs/wasm-bundler	Minor
@biomejs/wasm-nodejs	Minor
@biomejs/backend-jsonrpc	Patch
@biomejs/js-api	Major
@biomejs/prettier-compare	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codspeed-hq · 2026-01-21T23:01:28Z

Merging this PR will not alter performance

✅ 3 untouched benchmarks
🆕 1 new benchmark
⏩ 152 skipped benchmarks¹

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
🆕	`html_analyzer[index_1033418810622582172.html]`	N/A	398.9 µs	N/A

_{Comparing Netail:feat/name-reference-identifier (0befd10) with next (cb112ce)}

152 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

coderabbitai · 2026-01-22T16:51:22Z

Walkthrough

This changeset introduces support for HTML element names that can be reference identifiers rather than just literal tag names. The grammar is updated to define AnyHtmlTagName as a union of HtmlTagName and HtmlReferenceIdentifier. Across the codebase, value_token() calls are systematically replaced with name_value_token() for proper token retrieval. New formatter implementations are added for the HtmlReferenceIdentifier type, and type signatures are propagated throughout linters, formatters, and utilities to consistently use AnyHtmlTagName instead of HtmlTagName.

Possibly related PRs

feat(html/analyze): add useValidLang #8690: Directly modifies the same UseValidLang rule that receives token accessor updates in this PR.
feat(html): directives parsing and formatting #8719: Updates HTML grammar and formatter plumbing with new node unions, touching the same codegen/AST surface.
feat(biome_html_analyze): implement useAnchorContent rule for HTML #8769: Modifies the use_anchor_content accessibility lint that also receives tag-name handling updates here.

Suggested reviewers

ematipico
dyc3
arendjr

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding support for element names being reference identifiers in the HTML parser.
Description check	✅ Passed	The description relates to the changeset by explaining that it adds support for element names being reference identifiers, though it lacks specific implementation details.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

dyc3

There aren't any actual changes to the HTML parser so that it emits the new node.

I think the way this should work is that HtmlReferenceIdentifier should only be emitted if we are in a template language file (.vue, .svelte, etc.)

dyc3 · 2026-01-22T18:02:42Z

crates/biome_html_formatter/src/html/auxiliary/reference_identifier.rs

+        node: &HtmlReferenceIdentifier,
+        f: &mut HtmlFormatter,
+    ) -> FormatResult<()> {
+        format_html_verbatim_node(node.syntax()).fmt(f)


This needs to be actually formatted. This function marks the tokens as unformatted.

dyc3 · 2026-01-22T18:05:05Z

.changeset/pink-jars-care.md

+"@biomejs/biome": minor
+---
+
+Add support for the name of an element being a reference identifier


nit: should be past tense, should also mention the HTML parser

dyc3 · 2026-01-22T19:41:53Z

crates/biome_html_syntax/src/element_ext.rs

+                    && token
+                        .text_trimmed()
+                        .eq(token.text_trimmed().to_lowercase_cow().as_ref())


you can check if its all lowercase without the potential allocation. you can .iter().any(...) to check if any char is uppercase.

dyc3 · 2026-01-22T20:04:27Z

crates/biome_html_formatter/src/html/auxiliary/tag_name.rs

        let HtmlTagNameFields { value_token } = node.as_fields();

-        if should_lowercase_html_tag(f, node) {
+        if should_lowercase_html_tag(f, &node.clone().into()) {


I feel like the cloning could be avoided here.

dyc3 · 2026-01-22T20:06:14Z

crates/biome_html_formatter/src/utils/metadata.rs

 /// Returns `true` only for canonical HTML tags in pure HTML files (.html).
 /// Component frameworks preserve tag name casing.
-pub(crate) fn should_lowercase_html_tag(f: &HtmlFormatter, tag_name: &HtmlTagName) -> bool {
+pub(crate) fn should_lowercase_html_tag(f: &HtmlFormatter, tag_name: &AnyHtmlTagName) -> bool {


I actually don't think this change is necessary, and it would let you avoid the clone I mentioned in my previous comment.

Netail · 2026-01-30T12:46:12Z

Oh, I think this has been covered with #8886 already

feat(html_parser): add name reference identifier

0befd10

github-actions bot added A-Linter Area: linter A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools L-HTML Language: HTML and super languages labels Jan 21, 2026

Netail changed the title ~~feat(lsp): report progress while scanning the project (#7961)~~ feat(html_parser): add name reference identifier Jan 21, 2026

Netail marked this pull request as ready for review January 22, 2026 16:43

dyc3 requested changes Jan 22, 2026

View reviewed changes

Netail closed this Jan 30, 2026

Netail deleted the feat/name-reference-identifier branch January 30, 2026 12:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(html_parser): add name reference identifier#8827

feat(html_parser): add name reference identifier#8827
Netail wants to merge 1 commit intobiomejs:nextfrom
Netail:feat/name-reference-identifier

Netail commented Jan 21, 2026

Uh oh!

changeset-bot bot commented Jan 21, 2026

Uh oh!

codspeed-hq bot commented Jan 21, 2026

Uh oh!

coderabbitai bot commented Jan 22, 2026

Uh oh!

dyc3 left a comment

Uh oh!

dyc3 Jan 22, 2026

Uh oh!

dyc3 Jan 22, 2026

Uh oh!

dyc3 Jan 22, 2026

Uh oh!

dyc3 Jan 22, 2026

Uh oh!

dyc3 Jan 22, 2026

Uh oh!

Netail commented Jan 30, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Netail commented Jan 21, 2026

Summary

Test Plan

Docs

Uh oh!

changeset-bot bot commented Jan 21, 2026

🦋 Changeset detected

Uh oh!

codspeed-hq bot commented Jan 21, 2026

Merging this PR will not alter performance

Performance Changes

Footnotes

Uh oh!

coderabbitai bot commented Jan 22, 2026

Walkthrough

Possibly related PRs

Suggested reviewers

Uh oh!

dyc3 left a comment

Choose a reason for hiding this comment

Uh oh!

dyc3 Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

dyc3 Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

dyc3 Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

dyc3 Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

dyc3 Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Netail commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Netail commented Jan 30, 2026 •

edited

Loading