Skip to content

fix(parse/html/vue): accept colon modifier in vue directives#8817

Merged
dyc3 merged 1 commit intomainfrom
dyc3/issue-8765
Jan 22, 2026
Merged

fix(parse/html/vue): accept colon modifier in vue directives#8817
dyc3 merged 1 commit intomainfrom
dyc3/issue-8765

Conversation

@dyc3
Copy link
Contributor

@dyc3 dyc3 commented Jan 20, 2026

Summary

fixes #8765

Test Plan

added snapshots

Docs

@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2026

🦋 Changeset detected

Latest commit: c5e4e72

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added A-Parser Area: parser L-HTML Language: HTML and super languages labels Jan 20, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 20, 2026

Walkthrough

This PR fixes the Vue parser's handling of directive modifiers with a single colon by modifying the parse_vue_modifier function to conditionally consume HTML_LITERAL tokens when a colon follows. The change introduces a test case to validate the edge case syntax @keydown.:.stop.prevent and includes a changeset entry documenting the patch-level fix.

Possibly related PRs

Suggested labels

A-Parser, L-HTML

Suggested reviewers

  • ematipico
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing the Vue parser to accept colon modifiers in directives.
Description check ✅ Passed The description appropriately references the issue (#8765) and mentions the test plan, clearly relating to the changeset.
Linked Issues check ✅ Passed The PR fully addresses issue #8765 by modifying the Vue parser to accept colon modifiers in directives like @keydown.:, preventing panics.
Out of Scope Changes check ✅ Passed All changes are directly scoped to fixing the Vue directive parser for colon modifiers and include a test case; no extraneous changes detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@dyc3 dyc3 requested review from a team January 20, 2026 11:09
@dyc3 dyc3 added the D-Vue Domains: Vue label Jan 20, 2026
@dyc3 dyc3 merged commit 652cfbb into main Jan 22, 2026
13 checks passed
@dyc3 dyc3 deleted the dyc3/issue-8765 branch January 22, 2026 17:13
@github-actions github-actions bot mentioned this pull request Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Parser Area: parser D-Vue Domains: Vue L-HTML Language: HTML and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Vue parser fails with @keydown.:.stop.prevent="..."

2 participants