fix(justfile): remove errant run argument from test commands#8789
fix(justfile): remove errant run argument from test commands#8789ematipico merged 1 commit intobiomejs:mainfrom
run argument from test commands#8789Conversation
The `test` and `test-crate` recipes incorrectly used `cargo test run` instead of `cargo test`, causing most tests to be filtered out.
|
WalkthroughThis PR removes the incidental 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The error message for unclosed inline code spans was incorrectly showing
triple backticks (```) instead of the actual number of opening backticks.
For input like `This has `unclosed code`, the error said "expected closing
```" but should say "expected closing `".
The bug was in the format strings in `unclosed_code_span()` which wrapped
the `{backticks}` variable with literal backticks, adding 2 extra characters.
Since the variable already contained the correct backticks, this resulted in
3 backticks when only 1 was expected.
Also includes justfile fix from PR biomejs#8789 to remove errant `run` argument
from test commands.
The error message for unclosed inline code spans was incorrectly showing
triple backticks (```) instead of the actual number of opening backticks.
For input like `This has `unclosed code`, the error said "expected closing
```" but should say "expected closing `".
The bug was in the format strings in `unclosed_code_span()` which wrapped
the `{backticks}` variable with literal backticks, adding 2 extra characters.
Since the variable already contained the correct backticks, this resulted in
3 backticks when only 1 was expected.
Also includes justfile fix from PR biomejs#8789 to remove errant `run` argument
from test commands.
2 participants
Summary
In commit ef5fd3a, the test runner was switched from cargo nextest run to cargo test, but the word run was accidentally left in the command:
Before:
cargo nextest run --no-fail-fast(correct for nextest)After:
cargo test run --no-fail-fast(incorrect)With cargo test run, the word run is interpreted as a test name filter, causing cargo to only run tests containing "run" in their name. This filters out the vast majority of tests.
Test Plan
Ran
just testbefore and after the fix to confirm tests now execute properly rather than being filtered out.Docs
N/A - internal tooling fix.