Skip to content

fix(linter): add support for active-view-transition pseudo-class#8787

Merged
ematipico merged 2 commits intobiomejs:mainfrom
tuyuritio:fix/active-view-transition
Jan 18, 2026
Merged

fix(linter): add support for active-view-transition pseudo-class#8787
ematipico merged 2 commits intobiomejs:mainfrom
tuyuritio:fix/active-view-transition

Conversation

@tuyuritio
Copy link
Contributor

Summary

Adds :active-view-transition to the list of known CSS pseudo-classes in the noUnknownPseudoClass rule, which is part of the View Transitions API.

Fixes #8777

Test Plan

  1. Added a new test case in crates\biome_css_analyze\tests\specs\correctness\noUnknownPseudoClass\valid.css.
  2. Ran cargo test -p biome_css_analyze.

Docs

No documentation updated.

@changeset-bot
Copy link

changeset-bot bot commented Jan 18, 2026

🦋 Changeset detected

Latest commit: 4f67af2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added A-Linter Area: linter L-CSS Language: CSS labels Jan 18, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 18, 2026

Walkthrough

Adds support for the :active-view-transition pseudo‑class to the CSS linter. The OTHER_PSEUDO_CLASSES constant in crates/biome_css_analyze/src/keywords.rs was extended to include "active-view-transition" (array length 51 → 52). A changeset .changeset/warm-clowns-divide.md was added noting a patch release for @biomejs/biome. A test was added (crates/biome_css_analyze/tests/specs/correctness/noUnknownPseudoClass/valid.css) including a rule using :active-view-transition to validate the update.

Suggested reviewers

  • ematipico
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding support for the :active-view-transition pseudo-class to the CSS linter.
Description check ✅ Passed The description is well-related to the changeset, explaining what was added, why (View Transitions API), which issue it fixes, and the test plan executed.
Linked Issues check ✅ Passed All objectives from issue #8777 are met: :active-view-transition has been added to the noUnknownPseudoClass rule [#8777], a valid test case was added [#8777], and the implementation aligns with MDN documentation [#8777].
Out of Scope Changes check ✅ Passed All changes are directly scoped to the objective: the changeset file, the pseudo-class constant update, and the test case addition are all necessary to add :active-view-transition support.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-authored-by: Naoki Ikeguchi <me@s6n.jp>
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 18, 2026

Merging this PR will not alter performance

✅ 29 untouched benchmarks
⏩ 126 skipped benchmarks1


Comparing tuyuritio:fix/active-view-transition (4f67af2) with main (17ed9d3)2

Open in CodSpeed

Footnotes

  1. 126 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (72565bd) during the generation of this report, so 17ed9d3 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ematipico ematipico merged commit adb652f into biomejs:main Jan 18, 2026
18 checks passed
@github-actions github-actions bot mentioned this pull request Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Linter Area: linter L-CSS Language: CSS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

💅 Support :active-view-transition pseudo-class in CSS linter

3 participants