fix(biome_js_analyze): remove next/script name check for noBeforeInteractiveScriptOutsideDocument

[taga3s]

Summary

This PR removes next/script component name check from noBeforeInteractiveScriptOutsideDocument

I mistakenly added component name checking in the initial implementation (#8580). Since script component is a default export from next/script, it can be imported with any name.

Test Plan

• I added a test to check MyScript from next/script

Docs

[changeset-bot]

🦋 Changeset detected

Latest commit: 69d7308

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Walkthrough

This change modifies the noBeforeInteractiveScriptOutsideDocument lint rule to remove the JSX element-name guard that previously restricted checks to only elements named "Script". The rule now checks any element that imports from next/script with a beforeInteractive strategy attribute, accommodating cases where the component is imported with a different name. A test case is added to verify the updated behaviour with an aliased import.

Possibly related PRs

• feat(biome_js_analyze): port noBeforeInteractiveScriptOutsideDocument from Next.js #8580: Directly modifies the same lint rule implementation to remove the element-name check guard for default-exported next/script usages

Suggested labels

A-Linter, L-JavaScript, A-Diagnostic

Suggested reviewers

• dyc3
• Netail

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: removing the component name check from the noBeforeInteractiveScriptOutsideDocument rule.
Description check	✅ Passed	The description clearly explains the rationale for the change, references the original PR, and documents the test plan added.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 566c415 and 69d7308.

⛔ Files ignored due to path filters (2)

• crates/biome_js_analyze/tests/specs/nursery/noBeforeInteractiveScriptOutsideDocument/pages/invalid-01.jsx.snap is excluded by !**/*.snap and included by **
• crates/biome_js_analyze/tests/specs/nursery/noBeforeInteractiveScriptOutsideDocument/pages/invalid-02.jsx.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (4)

• .changeset/thin-rings-wait.md
• crates/biome_js_analyze/src/lint/nursery/no_before_interactive_script_outside_document.rs
• crates/biome_js_analyze/tests/specs/nursery/noBeforeInteractiveScriptOutsideDocument/pages/invalid-01.jsx
• crates/biome_js_analyze/tests/specs/nursery/noBeforeInteractiveScriptOutsideDocument/pages/invalid-02.jsx

🧰 Additional context used

📓 Path-based instructions (1)

**/*.rs

📄 CodeRabbit inference engine (CONTRIBUTING.md)

**/*.rs: Use inline rustdoc documentation for rules, assists, and their options
Use the dbg!() macro for debugging output in Rust tests and code
Use doc tests (doctest) format with code blocks in rustdoc comments; ensure assertions pass in tests

Files:

• crates/biome_js_analyze/src/lint/nursery/no_before_interactive_script_outside_document.rs

🧠 Learnings (14)

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/tests/specs/**/*invalid* : Create test files prefixed with `invalid` for code that should trigger the rule

Applied to files:

• crates/biome_js_analyze/tests/specs/nursery/noBeforeInteractiveScriptOutsideDocument/pages/invalid-02.jsx

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/tests/specs/**/*valid* : Create test files prefixed with `valid` for code that should not trigger the rule

Applied to files:

• crates/biome_js_analyze/tests/specs/nursery/noBeforeInteractiveScriptOutsideDocument/pages/invalid-02.jsx

📚 Learning: 2025-12-21T21:15:03.796Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-12-21T21:15:03.796Z
Learning: Changesets should describe user-facing changes only; internal refactoring without behavior changes does not require a changeset

Applied to files:

• .changeset/thin-rings-wait.md

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Set `language` to `jsx`, `ts`, or `tsx` for rules that only apply to specific JavaScript dialects

Applied to files:

• crates/biome_js_analyze/src/lint/nursery/no_before_interactive_script_outside_document.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/nursery/**/*.rs : Place new rules inside the `nursery` group during development

Applied to files:

• crates/biome_js_analyze/src/lint/nursery/no_before_interactive_script_outside_document.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Set `version` field to `next` in `declare_lint_rule!` macro

Applied to files:

• crates/biome_js_analyze/src/lint/nursery/no_before_interactive_script_outside_document.rs

📚 Learning: 2025-12-22T09:26:56.943Z

Learnt from: ematipico
Repo: biomejs/biome PR: 8537
File: crates/biome_js_analyze/src/lint/nursery/no_leaked_render.rs:167-210
Timestamp: 2025-12-22T09:26:56.943Z
Learning: When defining lint rules (declare_lint_rule!), only specify fix_kind if the rule implements an action(...) function. Rules that only emit diagnostics without a code fix should omit fix_kind. This applies to all Rust lint rule definitions under crates/.../src/lint (e.g., crates/biome_js_analyze/src/lint/...).

Applied to files:

• crates/biome_js_analyze/src/lint/nursery/no_before_interactive_script_outside_document.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : The first paragraph of rule documentation must be a single line describing what the rule does

Applied to files:

• crates/biome_js_analyze/src/lint/nursery/no_before_interactive_script_outside_document.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Use `RuleSource::Eslint(...).same()` when implementing a rule that matches the behavior of an ESLint rule

Applied to files:

• crates/biome_js_analyze/src/lint/nursery/no_before_interactive_script_outside_document.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Lint rules should perform static analysis of source code to detect invalid or error-prone patterns and emit diagnostics with proposed fixes

Applied to files:

• crates/biome_js_analyze/src/lint/nursery/no_before_interactive_script_outside_document.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Assist rules should detect refactoring opportunities and emit code action signals

Applied to files:

• crates/biome_js_analyze/src/lint/nursery/no_before_interactive_script_outside_document.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/nursery/**/*.rs : Add `issue_number` field to `declare_lint_rule!` macro for work-in-progress rules

Applied to files:

• crates/biome_js_analyze/src/lint/nursery/no_before_interactive_script_outside_document.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Specify `fix_kind: FixKind::Safe` in `declare_lint_rule!` for safe code actions

Applied to files:

• crates/biome_js_analyze/src/lint/nursery/no_before_interactive_script_outside_document.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Use `ctx.model()` to access semantic model information in a rule

Applied to files:

• crates/biome_js_analyze/src/lint/nursery/no_before_interactive_script_outside_document.rs

🧬 Code graph analysis (1)

crates/biome_js_analyze/tests/specs/nursery/noBeforeInteractiveScriptOutsideDocument/pages/invalid-02.jsx (1)

crates/biome_js_analyze/tests/specs/nursery/noBeforeInteractiveScriptOutsideDocument/pages/invalid-01.jsx (1)

• Index (4-13)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)

• GitHub Check: Test (depot-ubuntu-24.04-arm-16)
• GitHub Check: Lint project (depot-windows-2022)
• GitHub Check: Documentation
• GitHub Check: Check Dependencies
• GitHub Check: End-to-end tests
• GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
• GitHub Check: Test (depot-windows-2022-16)
• GitHub Check: Test Node.js API
• GitHub Check: Bench (biome_js_formatter)
• GitHub Check: Bench (biome_js_parser)
• GitHub Check: Bench (biome_js_analyze)
• GitHub Check: autofix

🔇 Additional comments (4)

crates/biome_js_analyze/src/lint/nursery/no_before_interactive_script_outside_document.rs (2)

94-109: LGTM! Solid fix for the aliased import issue.

Using semantic binding analysis via is_next_import rather than checking the element name is the correct approach for handling default exports. The logic correctly short-circuits when the binding isn't from next/script before proceeding to check the strategy attribute.

---

18-18: Documentation updated to match.

The wording now correctly refers to a generic next/script component rather than a specific <Script> tag, which aligns with the behavioural change.

.changeset/thin-rings-wait.md (1)

1-5: Changeset looks spot on.

Concise, user-facing description with the appropriate patch level for a bug fix. The reasoning is clear.

crates/biome_js_analyze/tests/specs/nursery/noBeforeInteractiveScriptOutsideDocument/pages/invalid-02.jsx (1)

1-13: Good test coverage for the aliased import scenario.

This directly validates the fix by using MyScript instead of Script. The test file follows the naming convention and placement requirements.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codspeed-hq]

CodSpeed Performance Report

Merging #8615 will not alter performance

_{Comparing taga3s:fix-to-remove-script-name-check (69d7308) with main (160236a)¹}

Summary

✅ 58 untouched
⏩ 95 skipped²

Footnotes

1. No successful run was found on main (566c415) during the generation of this report, so 160236a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 95 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩