chore: merge main to next by ematipico · Pull Request #8585 · biomejs/biome

ematipico · 2025-12-27T10:14:23Z

Summary

As per title.

Test Plan

Green CI

Docs

changeset-bot · 2025-12-27T10:14:27Z

⚠️ No Changeset found

Latest commit: 73fbe24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-12-27T10:18:37Z

Walkthrough

This change replaces CssRoot with AnyCssRoot across the module-graph and visitor codepaths (visitor constructor/field, update_graph_for_css_paths signature, workspace server specialization, and test utilities). Tests and test helpers now produce Vec<(&BiomePath, AnyCssRoot)>. CSS parsing calls were updated to pass a file source into parse_css. No traversal or visitor logic was functionally altered — only the root type and related signatures were broadened.

Possibly related PRs

feat(graph): support CSS files #8329: Broad CSS-root/type changes across module-graph and visitors — directly overlaps the same codepaths and types.
chore(core): add CSS variant information to the source file #8095: Adjusts CSS parsing/file-source handling and parser-option conversions used by the updated parse_css calls.
refactor(core): document services #8327: Refactors root/service-aware CSS semantics and threading of SendNode/CSS roots through workspace/analyser APIs, affecting the same representations.

Suggested labels

A-Parser, L-CSS, A-Core

Suggested reviewers

dyc3
arendjr

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'chore: merge main to next' accurately describes the PR's primary objective of merging the main branch into the next branch.
Description check	✅ Passed	The description directly relates to the changeset, stating 'As per title' and confirming the merge intent, though minimal detail is provided.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch chore/merge-main-next

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c698083 and 73fbe24.

📒 Files selected for processing (2)

Cargo.toml
crates/biome_yaml_formatter/Cargo.toml

✅ Files skipped from review due to trivial changes (1)

Cargo.toml

🧰 Additional context used

📓 Path-based instructions (1)

**/Cargo.toml

📄 CodeRabbit inference engine (CONTRIBUTING.md)

**/Cargo.toml: Use workspace dependencies with workspace = true for internal crates in Cargo.toml
Use path dependencies for dev-dependencies in crates to avoid requiring published versions

Files:

crates/biome_yaml_formatter/Cargo.toml

🧠 Learnings (20)

📓 Common learnings

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_parser/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:06:03.545Z
Learning: Applies to crates/biome_parser/**/*.ungram : Unions of nodes must start with `Any*`, e.g., `AnyHtmlAttribute`

📚 Learning: 2025-11-24T18:05:20.371Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:20.371Z
Learning: Applies to crates/biome_formatter/**/biome_*_formatter/Cargo.toml : Include development dependencies in `Cargo.toml` for formatter tests: `biome_formatter_test`, `biome_<language>_factory`, `biome_<language>_parser`, `biome_parser`, `biome_service`, `countme`, `iai`, `quickcheck`, `quickcheck_macros`, and `tests_macros`

Applied to files:

crates/biome_yaml_formatter/Cargo.toml

📚 Learning: 2025-12-21T21:15:03.796Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-12-21T21:15:03.796Z
Learning: Applies to **/Cargo.toml : Use workspace dependencies with `workspace = true` for internal crates in Cargo.toml

Applied to files:

crates/biome_yaml_formatter/Cargo.toml

📚 Learning: 2025-11-24T18:06:12.048Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_service/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:06:12.048Z
Learning: Applies to crates/biome_service/src/workspace*.rs : Implement the Workspace trait in the Biome Service to manage internal state of projects, including open documents, project layout instances, and module graph instances

Applied to files:

crates/biome_yaml_formatter/Cargo.toml

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Use `full_options` code block property for complete biome.json configuration snippets in documentation

Applied to files:

crates/biome_yaml_formatter/Cargo.toml

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Set `version` field to `next` in `declare_lint_rule!` macro

Applied to files:

crates/biome_yaml_formatter/Cargo.toml

📚 Learning: 2025-12-21T21:15:03.796Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-12-21T21:15:03.796Z
Learning: Applies to **/Cargo.toml : Use path dependencies for dev-dependencies in crates to avoid requiring published versions

Applied to files:

crates/biome_yaml_formatter/Cargo.toml

📚 Learning: 2025-12-04T13:29:49.287Z

Learnt from: dyc3
Repo: biomejs/biome PR: 8291
File: crates/biome_html_formatter/tests/specs/prettier/vue/html-vue/elastic-header.html:10-10
Timestamp: 2025-12-04T13:29:49.287Z
Learning: Files under `crates/biome_html_formatter/tests/specs/prettier` are test fixtures synced from Prettier and should not receive detailed code quality reviews (e.g., HTTP vs HTTPS, formatting suggestions, etc.). These files are test data meant to validate formatter behavior and should be preserved as-is.

Applied to files:

crates/biome_yaml_formatter/Cargo.toml

📚 Learning: 2025-11-24T18:06:03.545Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_parser/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:06:03.545Z
Learning: Create two new crates `biome_{language}_syntax` and `biome_{language}_factory` using `cargo new --lib` for new language parsers

Applied to files:

crates/biome_yaml_formatter/Cargo.toml

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/lib/**/*.rs : Wrap rule options fields in `Option<>` to properly track set and unset options during merge

Applied to files:

crates/biome_yaml_formatter/Cargo.toml

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Prefix line with `#` in documentation code examples sparingly; prefer concise complete snippets

Applied to files:

crates/biome_yaml_formatter/Cargo.toml

📚 Learning: 2025-12-21T21:15:03.796Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-12-21T21:15:03.796Z
Learning: Build debug binaries using `cargo build --bin biome` for development and triaging

Applied to files:

crates/biome_yaml_formatter/Cargo.toml

📚 Learning: 2025-11-24T18:05:20.371Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:20.371Z
Learning: Create a new formatter crate using the command `just new-crate biome_<language>_formatter` where `<language>` is the target language (e.g., `biome_html_formatter` for HTML)

Applied to files:

crates/biome_yaml_formatter/Cargo.toml

📚 Learning: 2025-11-24T18:05:20.371Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:20.371Z
Learning: Applies to crates/biome_formatter/**/biome_*_formatter/src/context.rs : Define `<Language>FormatContext` struct in a `context.rs` file containing `comments` and `source_map` fields, implementing `FormatContext` and `CstFormatContext` traits

Applied to files:

crates/biome_yaml_formatter/Cargo.toml

📚 Learning: 2025-11-24T18:05:27.810Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_js_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:27.810Z
Learning: Applies to crates/biome_js_formatter/**/*.rs : Import the `FormatNode` trait and implement it for your Node when creating formatters in biome_js_formatter

Applied to files:

crates/biome_yaml_formatter/Cargo.toml

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/lib/**/*.rs : Rule options must be placed inside the `biome_rule_options` crate

Applied to files:

crates/biome_yaml_formatter/Cargo.toml

📚 Learning: 2025-11-24T18:06:12.048Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_service/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:06:12.048Z
Learning: Debug the WorkspaceWatcher by starting the daemon with cargo run --bin=biome -- start and running commands such as cargo run --bin=biome -- lint --use-server <path>

Applied to files:

crates/biome_yaml_formatter/Cargo.toml

📚 Learning: 2025-11-24T18:06:12.048Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_service/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:06:12.048Z
Learning: Applies to crates/biome_service/src/workspace/watcher.tests.rs : Implement watcher tests for workspace methods in watcher.tests.rs and end-to-end tests in LSP tests

Applied to files:

crates/biome_yaml_formatter/Cargo.toml

📚 Learning: 2025-11-24T18:06:12.048Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_service/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:06:12.048Z
Learning: Applies to crates/biome_service/src/workspace/server.rs : Use WorkspaceServer implementation for maintaining workspace state in daemon mode and CLI daemonless mode

Applied to files:

crates/biome_yaml_formatter/Cargo.toml

📚 Learning: 2025-11-24T18:06:12.048Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_service/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:06:12.048Z
Learning: Applies to crates/biome_service/src/workspace_watcher.rs : Use WorkspaceWatcher to keep workspace state in sync with the filesystem, and only activate it in daemon mode

Applied to files:

crates/biome_yaml_formatter/Cargo.toml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

GitHub Check: Lint project (depot-windows-2022)
GitHub Check: Test (depot-windows-2022-16)
GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
GitHub Check: Test (depot-ubuntu-24.04-arm-16)
GitHub Check: Check Dependencies
GitHub Check: Documentation
GitHub Check: End-to-end tests
GitHub Check: Bench (biome_module_graph)

🔇 Additional comments (2)

crates/biome_yaml_formatter/Cargo.toml (2)

20-28: Workspace dependencies correctly configured.

All internal crates properly use workspace = true. Well done.

30-32: Path dependency correctly used; dev-dependencies appropriate.

The YAML formatter has no test files, so the minimal dev-dependencies are justified. The path dependency for biome_yaml_parser correctly follows guidelines.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codspeed-hq · 2025-12-27T10:19:28Z

CodSpeed Performance Report

Merging #8585 will not alter performance

_{Comparing chore/merge-main-next (73fbe24) with next (36d4165)}

Summary

✅ 4 untouched
⏩ 151 skipped¹

151 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

chore: merge main to next

c698083

github-actions bot added the A-Project Area: project label Dec 27, 2025

[autofix.ci] apply automated fixes

73fbe24

github-actions bot added the A-Formatter Area: formatter label Dec 27, 2025

ematipico merged commit 857d450 into next Dec 27, 2025
13 checks passed

ematipico deleted the chore/merge-main-next branch December 27, 2025 10:38

arthurfiorette mentioned this pull request Jan 3, 2026

feat(analyze/json): implement organizePackageJson #8659

Closed

coderabbitai bot mentioned this pull request Feb 11, 2026

chore: upgrade CVE'ed crates, remove unmaintaned crates #9032

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: merge main to next#8585

chore: merge main to next#8585
ematipico merged 2 commits intonextfrom
chore/merge-main-next

ematipico commented Dec 27, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Dec 27, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 27, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Dec 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

ematipico commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Docs

Uh oh!

changeset-bot bot commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

codspeed-hq bot commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #8585 will not alter performance

Summary

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ematipico commented Dec 27, 2025 •

edited

Loading

changeset-bot bot commented Dec 27, 2025 •

edited

Loading

coderabbitai bot commented Dec 27, 2025 •

edited

Loading

codspeed-hq bot commented Dec 27, 2025 •

edited

Loading