Skip to content

test: fix recent failures on next#8388

Merged
ematipico merged 1 commit intonextfrom
dyc3/fix-next-tests
Dec 8, 2025
Merged

test: fix recent failures on next#8388
ematipico merged 1 commit intonextfrom
dyc3/fix-next-tests

Conversation

@dyc3
Copy link
Contributor

@dyc3 dyc3 commented Dec 8, 2025 •
edited
Loading

Summary

This repairs CI health on next, and unblocks PRs currently pointing to next.

Not entirely sure how it slipped through, but it did somehow. This one test was assuming no diagnostics, and a recent lint rule ported to HTML caused it to start emitting diagnostics. I feel like that should have been caught in that PR, but maybe there's something i'm missing because im tired.

Edit: turns out it was that and other things too, probably related to merging main into next

Test Plan

CI should become green.

Docs

@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d975333

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the A-CLI Area: CLI label Dec 8, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 8, 2025 •
edited
Loading

Walkthrough

The PR updates a test fixture in crates/biome_cli/tests/cases/handle_vue_files.rs: the full_support_enabled_and_scss_is_skipped test now expects HTML with <html lang="en"><head><title>Vue</title></head><body></body></html> instead of the previous Svelte-specific markup. No code paths, logic or public API signatures were changed — this is a test-data correction.

Suggested reviewers

  • siketyan
  • ematipico

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly addresses the PR's purpose of fixing test failures on the next branch, matching the changeset which updates a test file.
Description check ✅ Passed The description clearly explains the motivation, root cause of test failures, and expected outcome, all directly related to the changeset.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dyc3/fix-next-tests
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 747c2af and d975333.

⛔ Files ignored due to path filters (3)
  • crates/biome_cli/tests/snapshots/main_cases_handle_vue_files/full_support_enabled_and_scss_is_skipped.snap is excluded by !**/*.snap and included by **
  • crates/biome_css_analyze/tests/specs/correctness/noUnknownUnit/valid.css.snap is excluded by !**/*.snap and included by **
  • crates/biome_js_analyze/tests/specs/correctness/noUnusedImports/jsxFactoryPreact.js.snap is excluded by !**/*.snap and included by **
📒 Files selected for processing (1)
  • crates/biome_cli/tests/cases/handle_vue_files.rs (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • crates/biome_cli/tests/cases/handle_vue_files.rs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Lint project (depot-windows-2022)
  • GitHub Check: Test (depot-windows-2022-16)

Comment @coderabbitai help to get the list of available commands and usage tips.

@dyc3 dyc3 changed the title tests: fix recent failures on next test: fix recent failures on next Dec 8, 2025
@dyc3 dyc3 marked this pull request as draft December 8, 2025 02:06
@dyc3 dyc3 force-pushed the dyc3/fix-next-tests branch from 747c2af to d975333 Compare December 8, 2025 02:08
@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS labels Dec 8, 2025
@dyc3 dyc3 marked this pull request as ready for review December 8, 2025 02:15
@dyc3 dyc3 requested review from a team December 8, 2025 02:15
@ematipico ematipico merged commit c6afa4a into next Dec 8, 2025
12 checks passed
@ematipico ematipico deleted the dyc3/fix-next-tests branch December 8, 2025 06:20
@arthurfiorette arthurfiorette mentioned this pull request Jan 3, 2026
Closed
@coderabbitai coderabbitai bot mentioned this pull request Feb 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

@siketyan siketyan siketyan approved these changes

Assignees

No one assigned

Labels

A-CLI Area: CLI A-Linter Area: linter L-CSS Language: CSS L-JavaScript Language: JavaScript and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dyc3 @ematipico @siketyan