Skip to content

ci: fix regression in benchmark workflows#8244

Merged
ematipico merged 1 commit intomainfrom
ci/benchmark-regression
Nov 24, 2025
Merged

ci: fix regression in benchmark workflows#8244
ematipico merged 1 commit intomainfrom
ci/benchmark-regression

Conversation

@ematipico
Copy link
Member

@ematipico ematipico commented Nov 24, 2025

Summary

I merged a pr that has a breaking change in the bench workflows. This PR fixes it

Test Plan

Merge and see if the bench jobs work

Docs

@changeset-bot
Copy link

changeset-bot bot commented Nov 24, 2025

⚠️ No Changeset found

Latest commit: ed0f965

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ematipico ematipico merged commit c485f96 into main Nov 24, 2025
3 of 4 checks passed
@ematipico ematipico deleted the ci/benchmark-regression branch November 24, 2025 18:03
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 24, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request adds mode: simulation parameter to the CodSpeed action across eight benchmark workflow files: benchmark_configuration.yml, benchmark_css.yml, benchmark_graphql.yml, benchmark_js.yml, benchmark_json.yml, benchmark_manifests.yml, benchmark_module_graph.yml, and benchmark_tailwind.yml. The parameter is consistently added within the with: block of each CodSpeed action invocation. One file also includes minor formatting adjustments to the workflow_dispatch trigger.

Possibly related PRs

  • ci: breakdown benchmarks #7641: Modifies the same benchmark workflow files and CodSpeed action configuration, adding sharding and related adjustments to benchmarks.

Suggested reviewers

  • siketyan
  • dyc3
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci/benchmark-regression

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3f19b52 and ed0f965.

📒 Files selected for processing (8)
  • .github/workflows/benchmark_configuration.yml (1 hunks)
  • .github/workflows/benchmark_css.yml (1 hunks)
  • .github/workflows/benchmark_graphql.yml (1 hunks)
  • .github/workflows/benchmark_js.yml (1 hunks)
  • .github/workflows/benchmark_json.yml (1 hunks)
  • .github/workflows/benchmark_manifests.yml (1 hunks)
  • .github/workflows/benchmark_module_graph.yml (1 hunks)
  • .github/workflows/benchmark_tailwind.yml (2 hunks)

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant