Revert "fix(lint/useExhaustiveDependencies): correct fix for method calls"

[siketyan]

Reverts #7709

Reverting for now as some users have complained about the new behaviour. It was to align the behaviour of the official react-hooks plugin, but the change was too big for a patch update.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 61737d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

This PR simplifies the dependency analysis logic in use_exhaustive_dependencies by removing a special-case handler that previously detected when a static member expression's root was a child of a call expression and would return the object part to circumvent prototype chain issues. The function now consistently casts the root directly instead of taking an early-exit path. Associated test cases from issue 7704 have also been removed.

Possibly related PRs

• fix(lint/useExhaustiveDependencies): correct fix for method calls #7709: Directly reverses this change—the predecessor PR introduced the special-case that this PR removes.
• fix(lint/useExhaustiveDependencies): correctly fix the dependency list from a shorthand object member #7498: Modifies the same dependency-collection logic in use_exhaustive_dependencies.rs for AST node interpretation.

Suggested labels

A-Linter, L-JavaScript

Suggested reviewers

• arendjr
• dyc3

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title "Revert "fix(lint/useExhaustiveDependencies): correct fix for method calls"" clearly indicates that this pull request is reverting a previous fix. The changeset shows removals from the use_exhaustive_dependencies.rs implementation and test file, which is consistent with reverting changes. A developer scanning the history would immediately understand that this is a revert operation for a method call-related fix. The title is specific, concise, and accurately summarises the main change.
Description Check	✅ Passed	The pull request description clearly states that it reverts a previous PR (#7709) and provides context for why this revert is necessary—user complaints about the new behaviour and concerns about the scope of the change for a patch release. This explanation directly aligns with the changeset, which removes code modifications to the use_exhaustive_dependencies linting rule and its associated test cases, effectively reverting the prior fix. The description is on-topic and relates meaningfully to the changes being made.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch revert-7709-fix/GH-7704

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codspeed-hq]

CodSpeed Performance Report

Merging #7810 will not alter performance

_{Comparing revert-7709-fix/GH-7704 (61737d8) with main (f1e3841)¹}

Summary

✅ 53 untouched
⏩ 85 skipped²

Footnotes

1. No successful run was found on main (aeaa70e) during the generation of this report, so f1e3841 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 85 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩