Skip to content

chore: add edition 2024 to rustfmt.toml#7591

Merged
siketyan merged 2 commits intobiomejs:mainfrom
turbocrime:fix/rustfmt-config-edition
Sep 25, 2025
Merged

chore: add edition 2024 to rustfmt.toml#7591
siketyan merged 2 commits intobiomejs:mainfrom
turbocrime:fix/rustfmt-config-edition

Conversation

@turbocrime
Copy link
Contributor

@turbocrime turbocrime commented Sep 24, 2025

fixes #7590

rustfmt now executes successfully during codegen xtasks and provides errors that are not edition errors

inline configuration is not necessary in xtask/src/lib.rs, because it will use the configuration file at the repo root.

simple lint failures that were undetected are now fixed.

@changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2025

⚠️ No Changeset found

Latest commit: eda4a53

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the A-Tooling Area: internal tools label Sep 24, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 24, 2025

Walkthrough

  • Added edition = "2024" to rustfmt.toml while keeping newline_style = "Unix" and style_edition = "2024".
  • Changed xtask/src/lib.rs so reformat_without_preamble calls rustfmt without explicit --config flags, relying on config files instead.
  • Updated various documentation comments (angle-bracketed/qualified crate links) across multiple crates.
  • No public/exported API signatures were changed.

Suggested labels

A-Formatter, A-Project

Suggested reviewers

  • siketyan

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Out of Scope Changes Check ⚠️ Warning The PR includes several unrelated documentation comment updates across multiple crates that are not necessary for resolving the rustfmt configuration issue described in issue #7590. Please move these unrelated documentation link changes into a separate PR or remove them to keep this change focused on the rustfmt edition configuration fix.
✅ Passed checks (4 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly describes the primary change of adding the 2024 edition to rustfmt.toml and clearly reflects the main focus of the PR.
Linked Issues Check ✅ Passed The PR adds the missing edition setting in rustfmt.toml and removes explicit inline flags in xtask, which ensures rustfmt now picks up the repository configuration and addresses the failure described in issue #7590.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description Check ✅ Passed The pull request description directly addresses issue #7590 and explains the removal of inline rustfmt configuration in favour of using the root rustfmt.toml, as well as noting the fix for simple lint failures. It clearly matches the changes made to rustfmt.toml and xtask/src/lib.rs without straying off-topic. The description is sufficiently specific to the scope of the diff.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added A-Project Area: project A-Parser Area: parser A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages labels Sep 25, 2025
@turbocrime
Copy link
Contributor Author

unsure how to changeset this, since the changeset tool does not indicate these changes belong to any package

@turbocrime turbocrime changed the title add edition 2024 to rustfmt.toml chore: add edition 2024 to rustfmt.toml Sep 25, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 25, 2025

✅ Actions performed

Running Pre-merge checks. Results will be posted in the summary comment once complete.

@turbocrime
Copy link
Contributor Author

turbocrime commented Sep 25, 2025

documentation updates are in response to the linter fix

@coderabbitai ignore pre-merge checks

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 25, 2025

@turbocrime Thanks for clarifying that the documentation updates are in response to the linter fix. That makes sense and explains the formatting changes to the URL references in the documentation comments.

I'll resolve all my review comments now.

✅ Actions performed

Comments resolved.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 25, 2025

✅ Actions performed

Pre-merge checks override command executed successfully.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 25, 2025

CodSpeed Performance Report

Merging #7591 will not alter performance

Comparing turbocrime:fix/rustfmt-config-edition (eda4a53) with main (cadad2c)

Summary

✅ 133 untouched

@siketyan siketyan merged commit 551bc32 into biomejs:main Sep 25, 2025
32 of 33 checks passed
@turbocrime turbocrime deleted the fix/rustfmt-config-edition branch September 25, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Formatter Area: formatter A-Parser Area: parser A-Project Area: project A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 xtask executes rustfmt without edition config

2 participants