Skip to content

ci: actually automate updating rule version metadata, for real this time#7430

Merged
dyc3 merged 1 commit intomainfrom
fix-version-meta-3
Sep 9, 2025
Merged

ci: actually automate updating rule version metadata, for real this time#7430
dyc3 merged 1 commit intomainfrom
fix-version-meta-3

Conversation

@dyc3
Copy link
Contributor

@dyc3 dyc3 commented Sep 7, 2025

Summary

Follow up to #7429. The job will now stash the changes to get around the git reset and reapply them later. We can't do a commit because the changeset cli resets to the branch to a specific commit, not to the current HEAD. https://github.com/changesets/action/blob/04d574e831923498156e0b2b93152878063203a3/src/git.ts#L100

Test Plan

We'll see if it works when it lands. I don't know if its actually required to have a new changeset to actually trigger the workflow to run.

Docs

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2025

⚠️ No Changeset found

Latest commit: adc1b95

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 7, 2025

Walkthrough

Removed .changeset/fluffy-jeans-cheat.md (placeholder-only file). Added a "Stash changes" step to .github/workflows/release.yml that runs git stash push -u -m __automated-changes after scripts/update-next-version.sh and before the Create Release Pull Request step. Updated package.json version script to attempt to pop that stash if present using a guarded command so missing stash is non-fatal.

Suggested labels

L-JavaScript, L-JSON

Suggested reviewers

  • ematipico

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a286c0 and adc1b95.

📒 Files selected for processing (3)
  • .changeset/fluffy-jeans-cheat.md (0 hunks)
  • .github/workflows/release.yml (1 hunks)
  • package.json (1 hunks)
💤 Files with no reviewable changes (1)
  • .changeset/fluffy-jeans-cheat.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/release.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Check JS Files
  • GitHub Check: Test Node.js API
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-version-meta-3

Comment @coderabbitai help to get the list of available commands and usage tips.

@dyc3 dyc3 force-pushed the fix-version-meta-3 branch from 71fabd0 to 6a286c0 Compare September 7, 2025 21:00
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4ea32f4 and 6a286c0.

📒 Files selected for processing (3)
  • .changeset/fluffy-jeans-cheat.md (0 hunks)
  • .github/workflows/release.yml (1 hunks)
  • package.json (1 hunks)
💤 Files with no reviewable changes (1)
  • .changeset/fluffy-jeans-cheat.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Check JS Files
  • GitHub Check: Test Node.js API

@dyc3 dyc3 force-pushed the fix-version-meta-3 branch from 6a286c0 to adc1b95 Compare September 7, 2025 21:21
Copy link
Member

@chansuke chansuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dyc3 dyc3 merged commit 0a5d3be into main Sep 9, 2025
6 checks passed
@dyc3 dyc3 deleted the fix-version-meta-3 branch September 9, 2025 14:47
kedevked pushed a commit to kedevked/biome that referenced this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants