feat(wasm): expose Workspace::scan_project_folder#7005
Conversation
|
| Name | Type |
|---|---|
| @biomejs/biome | Minor |
| @biomejs/wasm-bundler | Minor |
| @biomejs/wasm-nodejs | Minor |
| @biomejs/wasm-web | Minor |
| @biomejs/js-api | Major |
| @biomejs/cli-win32-x64 | Minor |
| @biomejs/cli-win32-arm64 | Minor |
| @biomejs/cli-darwin-x64 | Minor |
| @biomejs/cli-darwin-arm64 | Minor |
| @biomejs/cli-linux-x64 | Minor |
| @biomejs/cli-linux-arm64 | Minor |
| @biomejs/cli-linux-x64-musl | Minor |
| @biomejs/cli-linux-arm64-musl | Minor |
| @biomejs/backend-jsonrpc | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
| #[instrument(level = "debug", skip(ctx))] | ||
| fn scan_folder(folder: &Utf8Path, ctx: ScanContext) -> ScanFolderResult { | ||
| let start = Instant::now(); | ||
| let start = web_time::Instant::now(); |
There was a problem hiding this comment.
web_time::Instant is a drop-in replacement of std::time::Instant backed by performance.now() with wasm-bindgen.
CodSpeed Performance ReportMerging #7005 will not alter performanceComparing Summary
|
siketyan
force-pushed
the
feat/wasm-scanner
branch
from
9cfe24f to
bf11e53
Compare
.changeset/silly-colts-dress.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@biomejs/biome": patch | |||
There was a problem hiding this comment.
Since this change primarily affects the wasm packages, probably should also include the wasm packages in this list.
There was a problem hiding this comment.
@dyc3 Actually we only use @biomejs/biome and @biomejs/js-api for changing which packages to ship. Bumping @biomejs/biome also ships WASM packages.
There was a problem hiding this comment.
Right, but when the changelogs get rendered out, the change only shows up for a package if its listed in the changeset. Each package has it's own changelog.
There was a problem hiding this comment.
I agree, WASM API changes should be listed in the changelogs for @biome/wasm-*. However, we don't render changelogs for packages other than @biome/biome and @biome/js-api for now, so adding WASM packages is meaningless. Let me align it with #6896 for this time.
There was a problem hiding this comment.
I think @dyc3 makes a good point. We usually publish everything together, but we can add a changelog line for those packages. I can update the changeset of the other PR (as long as they all are patch/minor).
There was a problem hiding this comment.
I merged the changeset to yours, adding wasm-* packages to the list. be2d768
.changeset/silly-colts-dress.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@biomejs/biome": patch | |||
There was a problem hiding this comment.
I did the same here #6896 but merged into next. I think it's fine to have them shipped in patches, but we should agree how we should ship new APIs from core :)
There was a problem hiding this comment.
Didn't notice your PR 😔 Then should I close this as I suppose exposing update_module_graph is sufficient to enable project rules?
There was a problem hiding this comment.
I exposed those functions because I thought they were more useful for the playground, where there are single files.
The methods I exposed should be useful for project rules, however they require more plumbing.
This doesn't mean that this new method is useless, because we could use it for the JavaScript APIs as well :)
Let's merge the PR nonetheless :)
There was a problem hiding this comment.
I'll rebase this to next and ship with the methods you added :)
siketyan
force-pushed
the
feat/wasm-scanner
branch
from
bf11e53 to
19713e6
Compare
siketyan
force-pushed
the
feat/wasm-scanner
branch
from
19713e6 to
38de486
Compare
siketyan
force-pushed
the
feat/wasm-scanner
branch
from
38de486 to
be2d768
Compare
3 participants
Summary
Exposes a workspace method
scan_project_foldervia the WASM API. This will enable use of type inference and project rules in the playground.Test Plan
Manually tested with the playground locally.
Docs
N/A