refactor(formatter): specialised verbatim formatting#7002
Merged
Conversation
|
5e91015 to
8819a6d
Compare
CodSpeed Performance ReportMerging #7002 will not alter performanceComparing Summary
Footnotes |
siketyan
pushed a commit
that referenced
this pull request
Jul 26, 2025
vladimir-ivanov
pushed a commit
to vladimir-ivanov/biome
that referenced
this pull request
Aug 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
To fix #5356, we need to change the infrastructure of our formatter. At the moment our formatter is generic and tries to do everything itself, however if the specialised formatter want to change the default behaviour, they can't.
We'll have to change that, and each specialised formatter will have to implement their generic formatter.
Before applying this logic for comments, we need to start with verbatim and bogus nodes. This PR removes the verbatim/bogus utilities from
biome_formatter, and adds averbatim.rsmodule for each specialised formatter.The code, for now, it's repeated across modules.
Test Plan
CI should stay green
Docs