Conversation
c6265e4 to
2a0ef25
Compare
2a0ef25 to
1e3833a
Compare
|
I committed some changes to improve Note: I had to remove your last merge commit because it was removing features committed on main leading to many errors. |
|
I performed the merge with main. |
22deec1 to
bc7de20
Compare
4053581 to
c6731fd
Compare
CodSpeed Performance ReportMerging #5543 will not alter performanceComparing Summary
|
|
What do you think of my solution? |
I am unsure how this could work once we promote the GraphQL Also, some options make sense only in a given language. Should we then ignore them in the rules of a different language? |
Yes, they will inherit the same options, it's up to the rule to use them. There shouldn't be a runtime error.
That's a valid concern that we haven't tackled yet. Imho, if an option makes sense only for a given language, then the rule should have a very specific name that implies that it's used only in JavaScript files. The options could also be divided into different languages, e.g. {
"useNamingConvention": {
"javascript": {} // current options
"graphql": {} // options for graphql
}
} |
|
Regardless, as for now, I think we should rename the lint rule inside graphql. |
|
Co-authored-by: Victorien Elvinger <victorien@elvinger.fr> Co-authored-by: Conaclos <2358560+Conaclos@users.noreply.github.com> Co-authored-by: dyc3 <1808807+dyc3@users.noreply.github.com> Co-authored-by: arendjr <533294+arendjr@users.noreply.github.com>
Summary
Fix #6018
This PR refactors the rule options, which are now generated and shared among rules.
*_syntaxcrates anymoreTest Plan
No changes to the users, the CI should stay green.
I will update the contribution guide after we merge this one, which is already big enough