-
-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(format/grit): grit formatter initial configuration #3885
Conversation
CodSpeed Performance ReportMerging #3885 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. Thanks for the doc tweaks too.
I've been working on the HTML formatter recently, so if you have any questions, feel free to ping me here on GitHub or on discord
Check CONTRIBUTING.md for our PR title format |
fyi You can run |
Thanks! That's exactly what I was looking for. |
Summary
Create basic scaffolding/configuration for the GritQL formatter crate. I am realizing now that I probably started in the reverse order for the GritQL work, I probably should have started with the parser in hindsight.
With that said, this gets the bulk of the setup with the formatter out of the way, minus some tests. Will work to add that next.
#2476
Test Plan
It build successfully.