Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(format/grit): grit formatter initial configuration #3885

Merged
merged 16 commits into from
Sep 16, 2024

Conversation

branberry
Copy link
Contributor

@branberry branberry commented Sep 14, 2024

Summary

Create basic scaffolding/configuration for the GritQL formatter crate. I am realizing now that I probably started in the reverse order for the GritQL work, I probably should have started with the parser in hindsight.

With that said, this gets the bulk of the setup with the formatter out of the way, minus some tests. Will work to add that next.

#2476

Test Plan

It build successfully.

@github-actions github-actions bot added the A-Formatter Area: formatter label Sep 14, 2024
Copy link

codspeed-hq bot commented Sep 14, 2024

CodSpeed Performance Report

Merging #3885 will not alter performance

Comparing branberry:feat/gritql-setup (b7133b0) with main (ed79e0e)

Summary

✅ 107 untouched benchmarks

Copy link
Contributor

@dyc3 dyc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Thanks for the doc tweaks too.

I've been working on the HTML formatter recently, so if you have any questions, feel free to ping me here on GitHub or on discord

crates/biome_formatter/CONTRIBUTING.md Outdated Show resolved Hide resolved
@branberry branberry requested a review from dyc3 September 15, 2024 19:53
@branberry branberry marked this pull request as ready for review September 15, 2024 19:54
@branberry branberry changed the title (DRAFT): GritQL Formatter configuration GritQL Formatter configuration Sep 15, 2024
@dyc3
Copy link
Contributor

dyc3 commented Sep 15, 2024

Check CONTRIBUTING.md for our PR title format

@branberry branberry changed the title GritQL Formatter configuration feat: GritQL Formatter configuration Sep 15, 2024
@branberry branberry changed the title feat: GritQL Formatter configuration feat(format/grit): GritQL Formatter configuration Sep 15, 2024
@branberry branberry changed the title feat(format/grit): GritQL Formatter configuration feat(format/grit): grit formatter initial configuration Sep 15, 2024
@branberry branberry requested a review from dyc3 September 15, 2024 22:01
@dyc3
Copy link
Contributor

dyc3 commented Sep 15, 2024

fyi You can run just ready to run the CI checks locally.

@branberry
Copy link
Contributor Author

Thanks! That's exactly what I was looking for.

@dyc3 dyc3 merged commit 300d6c6 into biomejs:main Sep 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Formatter Area: formatter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants