Skip to content

Commit

Permalink
Resolve linting issues
Browse files Browse the repository at this point in the history
  • Loading branch information
branberry committed Sep 15, 2024
1 parent 9120f0c commit b7133b0
Show file tree
Hide file tree
Showing 6 changed files with 63 additions and 36 deletions.
10 changes: 0 additions & 10 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 3 additions & 12 deletions crates/biome_grit_formatter/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,9 @@ biome_grit_syntax = { workspace = true }
biome_rowan = { workspace = true }

[dev-dependencies]
biome_formatter_test = { path = "../biome_formatter_test" }
biome_grit_factory = { path = "../biome_grit_factory" }
biome_grit_parser = { path = "../biome_grit_parser" }
biome_parser = { path = "../biome_parser" }
biome_service = { path = "../biome_service" }
countme = { workspace = true, features = ["enable"] }
iai = "0.1.1"
quickcheck = { workspace = true }
quickcheck_macros = { workspace = true }
serde = { workspace = true, features = ["derive"] }
serde_json = { workspace = true }
tests_macros = { path = "../tests_macros" }
serde = { workspace = true, features = ["derive"] }
serde_json = { workspace = true }

# cargo-workspaces metadata
[package.metadata.workspaces]
independent = true
Expand Down
2 changes: 1 addition & 1 deletion crates/biome_grit_formatter/src/comments.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ impl CommentStyle for GritCommentStyle {
}

fn get_comment_kind(
comment: &biome_rowan::SyntaxTriviaPieceComments<Self::Language>,
_comment: &biome_rowan::SyntaxTriviaPieceComments<Self::Language>,
) -> biome_formatter::comments::CommentKind {
todo!()
}
Expand Down
1 change: 1 addition & 0 deletions crates/biome_grit_formatter/src/context.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ use biome_formatter::{
use biome_grit_syntax::GritLanguage;
use std::rc::Rc;

#[allow(dead_code)]
#[derive(Debug, Clone)]
pub struct GritFormatContext {
comments: Rc<GritComments>,
Expand Down
8 changes: 6 additions & 2 deletions crates/biome_grit_formatter/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ where
}
}

#[allow(dead_code)]
#[derive(Debug, Clone, Default)]
pub struct GritFormatLanguage {
options: GritFormatOptions,
Expand Down Expand Up @@ -124,8 +125,8 @@ impl FormatLanguage for GritFormatLanguage {

fn create_context(
self,
root: &biome_rowan::SyntaxNode<Self::SyntaxLanguage>,
source_map: Option<biome_formatter::TransformSourceMap>,
_root: &biome_rowan::SyntaxNode<Self::SyntaxLanguage>,
_source_map: Option<biome_formatter::TransformSourceMap>,
) -> Self::Context {
todo!()
}
Expand Down Expand Up @@ -187,6 +188,7 @@ where
/// Used to convert this object into an object that can be formatted.
///
/// The difference to [AsFormat] is that this trait takes ownership of `self`.
#[allow(dead_code)]
pub(crate) trait IntoFormat<Context> {
type Format: biome_formatter::Format<Context>;

Expand Down Expand Up @@ -219,6 +221,7 @@ where
}

/// Formatting specific [Iterator] extensions
#[allow(dead_code)]
pub(crate) trait FormattedIterExt {
/// Converts every item to an object that knows how to format it.
fn formatted<Context>(self) -> FormattedIter<Self, Self::Item, Context>
Expand All @@ -235,6 +238,7 @@ pub(crate) trait FormattedIterExt {

impl<I> FormattedIterExt for I where I: std::iter::Iterator {}

#[allow(dead_code)]
pub(crate) struct FormattedIter<Iter, Item, Context>
where
Iter: Iterator<Item = Item>,
Expand Down
63 changes: 52 additions & 11 deletions crates/biome_unicode_table/src/tables.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit b7133b0

Please sign in to comment.