Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(biome_diagnostics): use enumflags2 for DiagnosticTag #3785

Merged
merged 3 commits into from
Sep 4, 2024
Merged

refactor(biome_diagnostics): use enumflags2 for DiagnosticTag #3785

merged 3 commits into from
Sep 4, 2024

Conversation

Javimtib92
Copy link
Contributor

Summary

Part of #3157

Removes bit_flags from biome_diagnostics, and adds enumflags2.

I implemented BitOr and BitOrAssign because the deserialization requires the binary assignment operation.

Test Plan

I ran cargo t on the root and all tests passed. Current CI should pass

@github-actions github-actions bot added the A-Diagnostic Area: diagnostocis label Sep 4, 2024
@dyc3 dyc3 changed the title refactor(biome_diagnostics): use enumflags2 refactor(biome_diagnostics): use enumflags2 for DiagnosticTag Sep 4, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 4, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3785 will improve performances by 7.97%

Comparing Javimtib92:refactor/diagnostics-enum-flag (bec2995) with main (b367c68)

Summary

⚡ 1 improvements
✅ 106 untouched benchmarks

Benchmarks breakdown

Benchmark main Javimtib92:refactor/diagnostics-enum-flag Change
⚡ db_17847247775464589309.json[uncached] 16.6 ms 15.4 ms +7.97%

dyc3
dyc3 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@dyc3 dyc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as long as CI passes.

@dyc3 dyc3 merged commit c9a0e75 into biomejs:main Sep 4, 2024
12 checks passed
@Javimtib92 Javimtib92 deleted the refactor/diagnostics-enum-flag branch September 5, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conaclos Conaclos Conaclos approved these changes

@dyc3 dyc3 dyc3 approved these changes

Assignees
No one assigned
Labels
A-Diagnostic Area: diagnostocis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Javimtib92 @dyc3 @Conaclos