fix(js_format): fix js template element parentheses issue (#3780)

biomejs · Sep 4, 2024 · b367c68 · b367c68
1 parent 1ab9a92
commit b367c68
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 1 deletion.
diff --git a/crates/biome_js_formatter/src/syntax_rewriter.rs b/crates/biome_js_formatter/src/syntax_rewriter.rs
@@ -140,6 +140,12 @@ impl JsFormatSyntaxRewriter {
                 let prev_token = l_paren.prev_token();
                 // Keep parentheses around unknown expressions. Biome can't know the precedence.
                 if inner.kind().is_bogus()
+                    // Don't remove parentheses if the expression in js template element
+                    || inner.grand_parent().is_some_and(|parent|
+                        parent.grand_parent().is_some_and(|node|
+                            node.kind() == JsSyntaxKind::JS_TEMPLATE_ELEMENT
+                        )
+                    )
                     // Don't remove parentheses if the expression is a decorator
                     || inner.grand_parent().is_some_and(|node| node.kind() == JsSyntaxKind::JS_DECORATOR && decorator_expression_needs_parens(&inner))
                     // Don't remove parentheses if they have skipped trivia. We don't know for certain what the intended syntax is.

diff --git a/crates/biome_js_formatter/tests/specs/js/module/template/template.js b/crates/biome_js_formatter/tests/specs/js/module/template/template.js
@@ -58,4 +58,15 @@ which already had a linebreak so can be broken up
 message = `this is a long messsage a simple interpolation without a linebreak \${foo} <- like this\`;
 message = \`whereas this messsage has a linebreak in the interpolation \${
   foo
-} <- like this`;
+} <- like this`;
+
+// https://github.com/biomejs/biome/issues/3766
+const issus_3766 = `Lectures: ${doneCount}/${totalCount} | Mins: ${(doneSecs / 60).toFixed(
+    2,
+  )}/${(totalSecs / 60).toFixed(
+    2,
+  )}| Hours: ${(doneSecs / 3600).toFixed(
+    2,
+  )}/${(totalSecs / 3600).toFixed(
+    2,
+  )}`;
diff --git a/crates/biome_js_formatter/tests/specs/js/module/template/template.js.snap b/crates/biome_js_formatter/tests/specs/js/module/template/template.js.snap
@@ -66,6 +66,17 @@ message = `this is a long messsage a simple interpolation without a linebreak \$
 message = \`whereas this messsage has a linebreak in the interpolation \${
   foo
 } <- like this`;
+
+// https://github.com/biomejs/biome/issues/3766
+const issus_3766 = `Lectures: ${doneCount}/${totalCount} | Mins: ${(doneSecs / 60).toFixed(
+    2,
+  )}/${(totalSecs / 60).toFixed(
+    2,
+  )}| Hours: ${(doneSecs / 3600).toFixed(
+    2,
+  )}/${(totalSecs / 3600).toFixed(
+    2,
+  )}`;
 ```
 
 
@@ -169,6 +180,13 @@ message = `this is a long messsage a simple interpolation without a linebreak \$
 message = \`whereas this messsage has a linebreak in the interpolation \${
   foo
 } <- like this`;
+
+// https://github.com/biomejs/biome/issues/3766
+const issus_3766 = `Lectures: ${doneCount}/${totalCount} | Mins: ${(
+	doneSecs / 60
+).toFixed(2)}/${(totalSecs / 60).toFixed(2)}| Hours: ${(
+	doneSecs / 3600
+).toFixed(2)}/${(totalSecs / 3600).toFixed(2)}`;
 ```
 
 # Lines exceeding max width of 80 characters