Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(bench): pin bench libs #3772

Merged
merged 2 commits into from
Sep 4, 2024
Merged

chore(bench): pin bench libs #3772

merged 2 commits into from
Sep 4, 2024
+27 −27

Conversation

pnodet
Copy link
Contributor

@pnodet pnodet commented Sep 3, 2024

Closes #3196

@github-actions github-actions bot added the A-Tooling Area: internal tools label Sep 3, 2024
@pnodet pnodet marked this pull request as ready for review September 3, 2024 13:18
@pnodet
Copy link
Contributor Author

pnodet commented Sep 3, 2024

Hi @Sec-ant
I went ahead and pin the libs.

From the issue:

Additionally, we should use the pattern [name].[content-hash].[extension] to save and validate lib files.

But this seems to have been improved by #3159

Conaclos
Conaclos reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@Conaclos Conaclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason of switching of GitHub CDN to JsDelivr CDN?

@pnodet
Copy link
Contributor Author

pnodet commented Sep 4, 2024

Hi @Conaclos !

From the issue:

we should also use CDNs like jsDelivr to replace those raw.githubusercontent.com links for the benefit of the speed and accessibility across the world (yes, in some places the GitHub urls are blocked :( )

Conaclos
Conaclos approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@Conaclos Conaclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Conaclos Conaclos merged commit 7d97662 into biomejs:main Sep 4, 2024
11 checks passed
@pnodet pnodet deleted the pnodet-4 branch September 4, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conaclos Conaclos Conaclos approved these changes

Assignees
No one assigned
Labels
A-Tooling Area: internal tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📎 Pin bench libs
2 participants
@pnodet @Conaclos