Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bench): better tracking for graphql benches #3159

Merged
merged 9 commits into from
Jul 1, 2024

Conversation

ematipico
Copy link
Member

Summary

The benches for GraphQL were broken because we were tracking them using the file name we are parsing, and all of them are called schema.graphql.

Now, only for graphql, the files are tracked using their hash

Test Plan

The CI should show new files added

@github-actions github-actions bot added the A-Tooling Area: internal tools label Jun 10, 2024
Copy link
Contributor

github-actions bot commented Jun 10, 2024

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 50496 50496 0
Passed 49299 49299 0
Failed 1197 1197 0
Panics 0 0 0
Coverage 97.63% 97.63% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6536 6536 0
Passed 2085 2085 0
Failed 4451 4451 0
Panics 0 0 0
Coverage 31.90% 31.90% 0.00%

ts/babel

Test result main count This PR count Difference
Total 669 669 0
Passed 597 597 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.24% 89.24% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18246 18246 0
Passed 13983 13983 0
Failed 4263 4263 0
Panics 0 0 0
Coverage 76.64% 76.64% 0.00%

Copy link

codspeed-hq bot commented Jun 10, 2024

CodSpeed Performance Report

Merging #3159 will create unknown performance changes

Comparing bench/fix-graphql-benching (3a03f28) with main (2230e40)

Summary

🆕 105 new benchmarks
⁉️ 90 (👁 90) dropped benchmarks

Benchmarks breakdown

Benchmark main bench/fix-graphql-benching Change
👁 css_analyzer[bootstrap.css] 92.2 ms N/A N/A
🆕 css_analyzer[bootstrap_18416142857265205439.css] N/A 92.1 ms N/A
👁 css_analyzer[bulma.css] 78.8 ms N/A N/A
🆕 css_analyzer[bulma_15117074458139280020.css] N/A 78.7 ms N/A
👁 css_analyzer[foundation.css] 60.7 ms N/A N/A
🆕 css_analyzer[foundation_7285025277362245733.css] N/A 60.7 ms N/A
👁 css_analyzer[pure.css] 6.5 ms N/A N/A
🆕 css_analyzer[pure_9395922602181450299.css] N/A 6.5 ms N/A
👁 css_analyzer[tachyons.css] 43.2 ms N/A N/A
🆕 css_analyzer[tachyons_9066552643484828443.css] N/A 43.1 ms N/A
👁 css_formatter[bootstrap.css] 109.7 ms N/A N/A
🆕 css_formatter[bootstrap_18416142857265205439.css] N/A 109.5 ms N/A
👁 css_formatter[bulma.css] 108.6 ms N/A N/A
🆕 css_formatter[bulma_15117074458139280020.css] N/A 108.3 ms N/A
👁 css_formatter[foundation.css] 73.1 ms N/A N/A
🆕 css_formatter[foundation_7285025277362245733.css] N/A 73.5 ms N/A
👁 css_formatter[full.css] 1.2 s N/A N/A
🆕 css_formatter[full_5814491140539129161.css] N/A 1.2 s N/A
👁 css_formatter[materialize.css] 80.3 ms N/A N/A
🆕 css_formatter[materialize_13055388268705992476.css] N/A 80.1 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@ematipico ematipico merged commit e708fff into main Jul 1, 2024
10 checks passed
@ematipico ematipico deleted the bench/fix-graphql-benching branch July 1, 2024 15:53
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Tooling Area: internal tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants