fix(cli): don't emit diagnostics in stdin mode, and exit with error code #3726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-CLI
ematipico
force-pushed
the
fix/std-in-check
branch
from
3ad714e
to
3614f74
Compare
chansuke
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3633
The CLI was incorrectly emitting diagnostics, which isn't supposed to happen in
stdinmode. The formatter, for example, doesn't emit any diagnostics in case the contents aren't formatted.Also, now the CLI exits with an error code in case the contents aren't formatted. This is in line with how prettier works.
Test Plan
I updated the current tests based on the new requirements