refactor(js_semantic): minor changes #3416
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up of #3408
This PR aims to improve the code readability.
I renamed
BindingIndex
andReferenceIndex
intoBindingId
andReferenceId
and added the same methods asScopeId
.Note that I kept the internal representation
u32
because we don't need a niche optimization for them.Also, I removed
SemanticModelScopeReference
that is a duplicate ofReferenceId
.Test Plan
CI must pass.