refactor(js_semantic): wrap scope id for niche optimization and clarity #3408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR wraps every scope id into a dedicated type.
This improves readability (sometimes it is not clear if a
u32
is aTextSize
, a scope id or a binding id).This also allows niche optimization (we are using
NonZeroU32
internally) and thus reduces the size of every event.Test Plan
CI must pass.