fix(deserialize): unescape JSON strings #3414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Linter
Sec-ant
reviewed
Jul 11, 2024
ematipico
approved these changes
Jul 11, 2024
Co-authored-by: Emanuele Stoppa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the
biome_deserializedidn't unescape JSON strings.To fix this issue. I had to change the representation of
biome_deserialize::Text.If the string has no escape sequence, then we still don't allocate a string.
Conversely, if a string contains at least one escape sequence, then we allocate a string.
biome_deserialize::Textis analog tostd::borrow::Cow.Test Plan
I added a test.
I also added a test for #3412.