Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(js_analyze): improve restricted regex error meesages #3412

Merged
merged 1 commit into from
Jul 11, 2024
Merged

refactor(js_analyze): improve restricted regex error meesages #3412

merged 1 commit into from
Jul 11, 2024

Conversation

Conaclos
Copy link
Member

Summary

Improve error messages for invalid restricted regexes.

Test Plan

This is not currently testable because JSON serialization doesn't unescape \\.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jul 11, 2024
@Conaclos Conaclos merged commit 8eb0e8a into main Jul 11, 2024
14 checks passed
@Conaclos Conaclos deleted the conaclos/restricted-regex-improve-error-msgs branch July 11, 2024 15:21
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 11, 2024

CodSpeed Performance Report

Merging #3412 will not alter performance

Comparing conaclos/restricted-regex-improve-error-msgs (9cef3ef) with main (6b1e518)

Summary

✅ 108 untouched benchmarks

@Conaclos Conaclos mentioned this pull request Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Conaclos