fix(cli): prevent overwriting paths when using --staged
or --changed
options
#3074
+428
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3069
Context:
The PR #2726 overwrite the
biome (lint|format|check|ci)
command's target path when the path is empty.But, when using
--staged
and--changed
options, the path would be intentionally empty. When there is no file in staging (--staged
) or there is no difference from a certain branch (--changed
), the file to be executed need not exist.So, in this PR, make sure that paths are not overwritten when either
--staged
or--changed
is used.Test Plan
Added snapshot cases.
And manually tested
--staged
and--changed
commands.