feat(cli): execute commands without file paths #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unvalley
commented
May 6, 2024
arendjr
approved these changes
May 6, 2024
Conaclos
reviewed
May 6, 2024
Co-authored-by: Victorien Elvinger <[email protected]>
ematipico
approved these changes
May 6, 2024
| Args::from([("lint"), ""].as_slice()), | ||
| ); | ||
|
|
||
| assert!(result.is_ok(), "run_cli returned {result:?}"); |
There was a problem hiding this comment.
I think we forgot to add a snapshot assertion
There was a problem hiding this comment.
Ok, this is a test for ok (without lint errors ) case, I'll change this to a test that emits lint errors with snapshot.
| Args::from([("check"), ""].as_slice()), | ||
| ); | ||
|
|
||
| assert!(result.is_ok(), "run_cli returned {result:?}"); |
Co-authored-by: Emanuele Stoppa <[email protected]>
unvalley
changed the title
Conaclos
approved these changes
May 6, 2024
ah-yu
reviewed
May 31, 2024
| | TraversalMode::Lint { .. } | ||
| | TraversalMode::Format { .. } | ||
| | TraversalMode::CI { .. } => match current_dir() { | ||
| Ok(current_dir) => inputs.push(current_dir.into_os_string()), |
There was a problem hiding this comment.
Could we use the relative path instead of the absolute path here? It seems that our globs don't work well with absolute paths.
There was a problem hiding this comment.
If we remove the prefix of the current_dir, I think it would be the relative path. I'll check that.
There was a problem hiding this comment.
This could also improve hyperlinks in the CLI: generally IDE expects relative paths.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows
lint,format,checkandcicommands to be executed without the file paths argument.e.g.
biome lint .->biome lintCloses #2266
Test Plan
biome lint,biome format,biome checkby using bin