Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css_parser): css modules composes #3017

Merged
merged 6 commits into from
May 30, 2024
Merged

Conversation

denbezrukov
Copy link
Contributor

Summary

Close #3013

Test Plan

cargo test

@github-actions github-actions bot added A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools L-CSS Language: CSS labels May 29, 2024
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 593 593 0
Failed 69 69 0
Panics 0 0 0
Coverage 89.58% 89.58% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13441 13441 0
Failed 4205 4205 0
Panics 0 0 0
Coverage 76.17% 76.17% 0.00%

Copy link

codspeed-hq bot commented May 29, 2024

CodSpeed Performance Report

Merging #3017 will not alter performance

Comparing feat/css-modules-composes (eef1ee4) with main (4ed208a)

Summary

✅ 92 untouched benchmarks

@denbezrukov denbezrukov merged commit 508a914 into main May 30, 2024
16 checks passed
@denbezrukov denbezrukov deleted the feat/css-modules-composes branch May 30, 2024 08:20
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Formatter Area: formatter A-Parser Area: parser A-Tooling Area: internal tools L-CSS Language: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 <TITLE> CSS Formatter makes lowercase identifiers for composes in CSS Modules.
3 participants