Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 <TITLE> CSS Formatter makes lowercase identifiers for composes in CSS Modules. #3013

Closed
1 task done
denbezrukov opened this issue May 28, 2024 · 0 comments · Fixed by #3017
Closed
1 task done

🐛 <TITLE> CSS Formatter makes lowercase identifiers for composes in CSS Modules. #3013

denbezrukov opened this issue May 28, 2024 · 0 comments · Fixed by #3017
Assignees
@denbezrukov
Labels
A-Formatter Area: formatter L-CSS Language: CSS S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@denbezrukov
Copy link
Contributor

Environment information

Playground link is enough.

What happened?

.a {
  composes: globalClassName from global;
}

becomes:

.a {
  composes: globalclassname from global;
}

Playground:

https://biomejs.dev/playground/?indentStyle=space&quoteStyle=single&jsxQuoteStyle=single&lintRules=all&files.main.css=LgBhACAAewAKACAAIABjAG8AbQBwAG8AcwBlAHMAOgAgAGcAbABvAGIAYQBsAGMAbABhAHMAcwBOAGEAbQBlACAAZgByAG8AbQAgAGcAbABvAGIAYQBsADsACgB9AA%3D%3D

Expected result

The formatter shouldn't lowercase identifiers for composes.

.a {
  composes: globalClassName from global;
}

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@denbezrukov denbezrukov self-assigned this May 28, 2024
@denbezrukov denbezrukov added A-Formatter Area: formatter L-CSS Language: CSS S-Bug-confirmed Status: report has been confirmed as a valid bug labels May 28, 2024
@denbezrukov denbezrukov mentioned this issue May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denbezrukov denbezrukov

Labels
A-Formatter Area: formatter L-CSS Language: CSS S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(css_parser): css modules composes biomejs/biome
1 participant
@denbezrukov