feat(configuration): add support for {a,b} glob patterns, gated behind an internal flag
#2989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One idea: We could add a boolean field in |
|
I like that. It would allow us to unblock #2971 without modifying the repo's |
…ind an internal flag
dyc3
changed the title
{a,b} glob patterns{a,b} glob patterns, gated behind an internal flag
|
Updated. I've intentionally left out the changes required for editorconfig patterns actually getting treated properly using this new flag because I believe those changes will be a bit more complicated. |
Conaclos
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This implements the "at least one of these" syntax for glob patterns as discussed in #2986. The intention is to bring our glob pattern parsing closer to what the Editorconfig spec allows for, so that we can have better Editorconfig support.
This is possibly a breaking change since the
{and}characters now have special meaning, and as such it would probably be better to leave this for biome 2.0. It's likely this PR will get stale in that time, but at minimum the test cases in this PR could remain useful to have.closes #2986
Test Plan
added tests