-
-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(editorconfig): reenable editorconfig loading #2971
Conversation
24c30ff
to
a9247e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't enable it until we have a configuration.
This very repository runs biome check
, and it fails because the editorconfig throws a parsing error. That's the reason why I disabled in the first place
I see two options:
- add the config
- print only warnings
Ah, ok, I misunderstood. I'll mark this as draft until the config gets added. It's likely emitting diagnostics for this (but they should only be warnings): [{**.yml,**.md,**.rs,**.mdx,justfile,**.json}]
indent_style = space Which is intentional, because biome can't parse these kinds of glob patterns. The easy fix for this would be to just separate this override into multiple overrides. Would we want to support this glob pattern syntax? |
Definitely, yes! |
a9247e7
to
2aa9e1d
Compare
I've updated this PR to change the editorconfig so that it can be parsed by biome. Which should allow the |
Closing this because this conflicts with another PR I'm working on. |
Summary
This was disabled in #2943.
related to: #1724
Test Plan
CI should pass, and
pnpm check:apply
should work without throwing errors