fix(workspace): remove caching of file features

[ematipico]

Summary

Closes #2781

The issue was the aggressive caching of FileFeatureResult, maybe designed with poor judgement from my side.

Here's the issue explained: when a file is opened, the LSP request diagnostics from a certain file. We pull diagnostics using these feature set:

        let file_features = self.workspace.file_features(SupportsFeatureParams {
            features: FeaturesBuilder::new()
                .with_linter()
                .with_organize_imports()
                .build(),
            path: biome_path.clone(),
        })?;

A formatter doesn't have proper diagnostics, so we exclude it from the features. Since the formatter feature isn't requested, the default value is used, which is Supported because ignore part is checked only on a parameter basis.

However, this was then cached inside our workspace.

When calling the formatting, we pull the formatter feature:

    let file_features = session.workspace.file_features(SupportsFeatureParams {
        path: biome_path.clone(),
        features: FeaturesBuilder::new().with_formatter().build(),
    })?;

Which is flagged as Supported because we retrieve the cached value.

As for a solution, for now, I removed the cache.

I plan to re-introduce the caching again, but I plan to rewrite the logic is a more pure way.

Test Plan

I manually tested it.