-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 formatOnSave
does not respect formatter.ignore
#2781
Closed
2 of 3 tasks
jrson83 opened this issue
May 3, 2024
· 5 comments
· Fixed by #2939 · May be fixed by abdulrahman305/continue#2
Closed
2 of 3 tasks
🐛 formatOnSave
does not respect formatter.ignore
#2781
jrson83 opened this issue
May 3, 2024
· 5 comments
· Fixed by #2939 · May be fixed by abdulrahman305/continue#2
Labels
A-LSP
Area: language server protocol
A-Project
Area: project
S-Bug-confirmed
Status: report has been confirmed as a valid bug
Comments
Moving this to the main repo, because it appears to be related to the LSP. |
ematipico
added
A-Project
Area: project
S-Bug-confirmed
Status: report has been confirmed as a valid bug
labels
May 20, 2024
The reproduction #2781 (comment) isn't valid, because it relies on nested @jrson83 can you provide a minimal reproduction? |
ematipico
added
S-Needs repro
Status: needs a reproduction
and removed
S-Bug-confirmed
Status: report has been confirmed as a valid bug
labels
May 21, 2024
@ematipico see the actual issue above I already provided an example: git clone https://github.com/jrson83/biome-ignore-issue.git
cd biome-ignore-issue
pnpm install |
Thank you |
ematipico
added
S-Bug-confirmed
Status: report has been confirmed as a valid bug
and removed
S-Needs repro
Status: needs a reproduction
labels
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-LSP
Area: language server protocol
A-Project
Area: project
S-Bug-confirmed
Status: report has been confirmed as a valid bug
VS Code version
1.89.0
Extension version
2.2.2
Biome version
1.7.2
Operating system
Description
This issue is identical to biomejs/biome-vscode#189 which has been fixed for
files.ignore
.If 'format on save' is turned on, using
formatter.ignore
the Biome.js extension will format files that should be ignored.Using
files.ignore
the issue is fixed.Using
formatter.ignore
the issue still persists.Steps to reproduce
git clone https://github.com/jrson83/biome-ignore-issue.git cd biome-ignore-issue pnpm install
packages/core/src/no-format.js
and save the file, you see it formats.Expected behavior
files.ignore
, I expect the same behaviour usingformatter.ignore
.pnpm run format
the files are NOT formatted.Does this issue occur when using the CLI directly?
No
Logs
No response
The text was updated successfully, but these errors were encountered: