feat(biome_deserialize): implement necessary traits for #[deserializable(rest)]
#2857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicholasLYang
force-pushed
the
feat/impl-deserializable-for-serde-value
branch
from
d55f312
to
7f825e4
Compare
NicholasLYang
force-pushed
the
feat/impl-deserializable-for-serde-value
branch
from
7f825e4
to
9d07721
Compare
CodSpeed Performance ReportMerging #2857 will not alter performanceComparing Summary
|
Conaclos
reviewed
May 14, 2024
Conaclos
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To facilitate #2757, we need a generic
Value. We decided on implementingDeserializableonserde_json::Value. This also implementsPartialOrdandOrderonText, so we can collect fields into aBTreeMapTest Plan