feat(biome_deserialize): implement necessary traits for `#[deserializ…

…able(rest)]` (#2857)
biomejs · May 14, 2024 · 753ed41 · 753ed41
1 parent 9c920a1
commit 753ed41
Show file tree

Hide file tree

Showing 4 changed files with 112 additions and 0 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/biome_deserialize/Cargo.toml b/crates/biome_deserialize/Cargo.toml
@@ -21,10 +21,12 @@ bitflags                 = { workspace = true }
 indexmap                 = { workspace = true, features = ["serde"] }
 schemars                 = { workspace = true, optional = true }
 serde                    = { workspace = true }
+serde_json               = { workspace = true, optional = true }
 smallvec                 = { workspace = true, optional = true }
 
 [features]
 schema   = ["schemars", "schemars/indexmap"]
+serde    = ["serde_json"]
 smallvec = ["dep:smallvec"]
 
 [lints]

diff --git a/crates/biome_deserialize/src/impls.rs b/crates/biome_deserialize/src/impls.rs
@@ -25,6 +25,19 @@ impl Text {
         self.0.text()
     }
 }
+
+impl PartialOrd for Text {
+    fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
+        Some(self.cmp(other))
+    }
+}
+
+impl Ord for Text {
+    fn cmp(&self, other: &Self) -> std::cmp::Ordering {
+        self.text().cmp(other.text())
+    }
+}
+
 impl Deref for Text {
     type Target = str;
     fn deref(&self) -> &Self::Target {

diff --git a/crates/biome_deserialize/src/json.rs b/crates/biome_deserialize/src/json.rs
@@ -138,6 +138,102 @@ impl DeserializableValue for AnyJsonValue {
     }
 }
 
+#[cfg(feature = "serde")]
+impl Deserializable for serde_json::Value {
+    fn deserialize(
+        value: &impl DeserializableValue,
+        name: &str,
+        diagnostics: &mut Vec<DeserializationDiagnostic>,
+    ) -> Option<Self> {
+        struct Visitor;
+        impl DeserializationVisitor for Visitor {
+            type Output = serde_json::Value;
+            const EXPECTED_TYPE: VisitableType = VisitableType::all();
+            fn visit_null(
+                self,
+                _range: biome_rowan::TextRange,
+                _name: &str,
+                _diagnostics: &mut Vec<DeserializationDiagnostic>,
+            ) -> Option<Self::Output> {
+                Some(serde_json::Value::Null)
+            }
+
+            fn visit_bool(
+                self,
+                value: bool,
+                _range: biome_rowan::TextRange,
+                _name: &str,
+                _diagnostics: &mut Vec<DeserializationDiagnostic>,
+            ) -> Option<Self::Output> {
+                Some(serde_json::Value::Bool(value))
+            }
+
+            fn visit_number(
+                self,
+                value: TextNumber,
+                _range: biome_rowan::TextRange,
+                _name: &str,
+                diagnostics: &mut Vec<DeserializationDiagnostic>,
+            ) -> Option<Self::Output> {
+                match serde_json::from_str(value.text()) {
+                    Ok(num) => Some(serde_json::Value::Number(num)),
+                    Err(err) => {
+                        diagnostics.push(DeserializationDiagnostic::new(err.to_string()));
+                        None
+                    }
+                }
+            }
+
+            fn visit_str(
+                self,
+                value: Text,
+                _range: biome_rowan::TextRange,
+                _name: &str,
+                _diagnostics: &mut Vec<DeserializationDiagnostic>,
+            ) -> Option<Self::Output> {
+                Some(serde_json::Value::String(value.text().to_string()))
+            }
+
+            fn visit_array(
+                self,
+                values: impl Iterator<Item = Option<impl DeserializableValue>>,
+                _range: biome_rowan::TextRange,
+                _name: &str,
+                diagnostics: &mut Vec<DeserializationDiagnostic>,
+            ) -> Option<Self::Output> {
+                Some(serde_json::Value::Array(
+                    values
+                        .filter_map(|value| Deserializable::deserialize(&value?, "", diagnostics))
+                        .collect(),
+                ))
+            }
+
+            fn visit_map(
+                self,
+                members: impl Iterator<
+                    Item = Option<(impl DeserializableValue, impl DeserializableValue)>,
+                >,
+                _range: biome_rowan::TextRange,
+                _name: &str,
+                diagnostics: &mut Vec<DeserializationDiagnostic>,
+            ) -> Option<Self::Output> {
+                Some(serde_json::Value::Object(
+                    members
+                        .filter_map(|entry| {
+                            let (key, value) = entry?;
+                            let key = Deserializable::deserialize(&key, "", diagnostics)?;
+                            let value = value.deserialize(Visitor, "", diagnostics)?;
+                            Some((key, value))
+                        })
+                        .collect(),
+                ))
+            }
+        }
+
+        value.deserialize(Visitor, name, diagnostics)
+    }
+}
+
 impl DeserializableValue for JsonMemberName {
     fn range(&self) -> biome_rowan::TextRange {
         AstNode::range(self)