refactor(analyze): add language field to rule metadata

crates/biome_analyze/CONTRIBUTING.md

@@ -183,6 +183,9 @@ The documentation needs to adhere to the following rules:
 - When adding _invalid_ snippets in the `### Invalid` section, you must use the `expect_diagnostic` code block property. We use this property to generate a diagnostic and attach it to the snippet. A snippet **must emit only ONE diagnostic**.
 - When adding _valid_ snippets in the `### Valid` section, you can use one single snippet.
 - You can use the code block property `ignore` to tell the code generation script to **not generate a diagnostic for an invalid snippet**.
+- Update the `language` field in the `declare_rule!` macro to the language the rule primarily applies to.
+  - If your rule applies to any JavaScript, you can leave it as `js`.
+  - If your rule only makes sense in a specific JavaScript dialect, you should set it to `jsx`, `ts`, or `tsx`, whichever is most appropriate.
 
 Here's an example of how the documentation could look like:
 
@@ -218,6 +221,7 @@ declare_rule! {
     pub(crate) NoVar {
         version: "next",
         name: "noVar",
+        language: "js",
         recommended: false,
     }
 }
@@ -373,6 +377,7 @@ declare_rule! {
     pub(crate) NoVar {
         version: "1.0.0",
         name: "noVar",
+        language: "js",
         deprecated: "Use the rule `noAnotherVar`",
         recommended: false,
     }
@@ -495,6 +500,7 @@ declare_rule! {
     pub(crate) ExampleRule {
         version: "next",
         name: "myRuleName",
+        language: "js",
         recommended: false,
     }
 }
@@ -516,6 +522,7 @@ declare_rule! {
     pub(crate) ExampleRule {
         version: "next",
         name: "myRuleName",
+        language: "js",
         recommended: false,
     }
 }

crates/biome_analyze/src/rule.rs

@@ -28,6 +28,8 @@ pub struct RuleMetadata {
     pub name: &'static str,
     /// The content of the documentation comments for this rule
     pub docs: &'static str,
+    /// The language that the rule applies to.
+    pub language: &'static str,
     /// Whether a rule is recommended or not
     pub recommended: bool,
     /// The kind of fix
@@ -242,12 +244,18 @@ impl RuleSourceKind {
 }
 
 impl RuleMetadata {
-    pub const fn new(version: &'static str, name: &'static str, docs: &'static str) -> Self {
+    pub const fn new(
+        version: &'static str,
+        name: &'static str,
+        docs: &'static str,
+        language: &'static str,
+    ) -> Self {
         Self {
             deprecated: None,
             version,
             name,
             docs,
+            language,
             recommended: false,
             fix_kind: None,
             sources: &[],
@@ -282,6 +290,11 @@ impl RuleMetadata {
         self.source_kind = Some(source_kind);
         self
     }
+
+    pub const fn language(mut self, language: &'static str) -> Self {
+        self.language = language;
+        self
+    }
 }
 
 pub trait RuleMeta {
@@ -315,6 +328,7 @@ macro_rules! declare_rule {
     ( $( #[doc = $doc:literal] )+ $vis:vis $id:ident {
         version: $version:literal,
         name: $name:tt,
+        language: $language:literal,
         $( $key:ident: $value:expr, )*
     } ) => {
         $( #[doc = $doc] )*
@@ -323,7 +337,7 @@ macro_rules! declare_rule {
         impl $crate::RuleMeta for $id {
             type Group = super::Group;
             const METADATA: $crate::RuleMetadata =
-                $crate::RuleMetadata::new($version, $name, concat!( $( $doc, "\n", )* )) $( .$key($value) )*;
+                $crate::RuleMetadata::new($version, $name, concat!( $( $doc, "\n", )* ), $language) $( .$key($value) )*;
         }
 
         // Declare a new `rule_category!` macro in the module context that

crates/biome_css_analyze/src/lint/nursery/no_color_invalid_hex.rs

@@ -27,6 +27,7 @@ declare_rule! {
     pub NoColorInvalidHex {
         version: "next",
         name: "noColorInvalidHex",
+        language: "css",
         recommended: false,
     }
 }

crates/biome_css_analyze/src/lint/nursery/no_css_empty_block.rs

@@ -61,6 +61,7 @@ declare_rule! {
     pub NoCssEmptyBlock {
         version: "next",
         name: "noCssEmptyBlock",
+        language: "css",
         recommended: true,
         sources: &[RuleSource::Stylelint("no-empty-block")],
     }

crates/biome_css_analyze/src/lint/nursery/no_duplicate_at_import_rules.rs

@@ -46,6 +46,7 @@ declare_rule! {
     pub NoDuplicateAtImportRules {
         version: "next",
         name: "noDuplicateAtImportRules",
+        language: "css",
         recommended: true,
         sources: &[RuleSource::Stylelint("no-duplicate-at-import-rules")],
     }

crates/biome_css_analyze/src/lint/nursery/no_duplicate_font_names.rs

@@ -43,6 +43,7 @@ declare_rule! {
     pub NoDuplicateFontNames {
         version: "next",
         name: "noDuplicateFontNames",
+        language: "css",
         recommended: true,
         sources: &[RuleSource::Stylelint("font-family-no-duplicate-names")],
     }

crates/biome_css_analyze/src/lint/nursery/no_duplicate_selectors_keyframe_block.rs

@@ -37,6 +37,7 @@ declare_rule! {
     pub NoDuplicateSelectorsKeyframeBlock {
         version: "next",
         name: "noDuplicateSelectorsKeyframeBlock",
+        language: "css",
         recommended: true,
         sources:&[RuleSource::Stylelint("keyframe-block-no-duplicate-selectors")],
     }

crates/biome_css_analyze/src/lint/nursery/no_important_in_keyframe.rs

@@ -41,6 +41,7 @@ declare_rule! {
     pub NoImportantInKeyframe {
         version: "next",
         name: "noImportantInKeyframe",
+        language: "css",
         recommended: true,
         sources:&[RuleSource::Stylelint("keyframe-declaration-no-important")],
     }

crates/biome_css_analyze/src/lint/nursery/no_invalid_position_at_import_rule.rs

@@ -27,6 +27,7 @@ declare_rule! {
     pub NoInvalidPositionAtImportRule {
         version: "next",
         name: "noInvalidPositionAtImportRule",
+        language: "css",
         recommended: true,
         sources: &[RuleSource::Stylelint("no-invalid-position-at-import-rule")],
     }

crates/biome_css_analyze/src/lint/nursery/no_unknown_function.rs

@@ -32,6 +32,7 @@ declare_rule! {
     pub NoUnknownFunction {
         version: "next",
         name: "noUnknownFunction",
+        language: "css",
         recommended: true,
         sources: &[RuleSource::Stylelint("function-no-unknown")],
     }

crates/biome_css_analyze/src/lint/nursery/no_unknown_media_feature_name.rs

@@ -67,6 +67,7 @@ declare_rule! {
     pub NoUnknownMediaFeatureName {
         version: "next",
         name: "noUnknownMediaFeatureName",
+        language: "css",
         recommended: false,
         sources: &[RuleSource::Stylelint("media-feature-name-no-unknown")],
     }

crates/biome_css_analyze/src/lint/nursery/no_unknown_property.rs

@@ -56,6 +56,7 @@ declare_rule! {
     pub NoUnknownProperty {
         version: "next",
         name: "noUnknownProperty",
+        language: "css",
         recommended: false,
     }
 }

crates/biome_css_analyze/src/lint/nursery/no_unknown_selector_pseudo_element.rs

@@ -49,6 +49,7 @@ declare_rule! {
     pub NoUnknownSelectorPseudoElement {
         version: "next",
         name: "noUnknownSelectorPseudoElement",
+        language: "css",
         recommended: true,
         sources: &[RuleSource::Stylelint("selector-pseudo-element-no-unknown")],
     }

crates/biome_css_analyze/src/lint/nursery/no_unknown_unit.rs

@@ -59,6 +59,7 @@ declare_rule! {
     pub NoUnknownUnit {
         version: "next",
         name: "noUnknownUnit",
+        language: "css",
         recommended: true,
         sources: &[RuleSource::Stylelint("unit-no-unknown")],
     }

crates/biome_css_analyze/src/lint/nursery/no_unmatchable_anb_selector.rs

@@ -53,6 +53,7 @@ declare_rule! {
     pub NoUnmatchableAnbSelector {
         version: "next",
         name: "noUnmatchableAnbSelector",
+        language: "css",
         recommended: true,
         sources: &[RuleSource::Stylelint("selector-anb-no-unmatchable")],
     }

crates/biome_css_analyze/src/lint/nursery/use_generic_font_names.rs

@@ -60,6 +60,7 @@ declare_rule! {
     pub UseGenericFontNames {
         version: "next",
         name: "useGenericFontNames",
+        language: "css",
         recommended: true,
         sources: &[RuleSource::Stylelint("font-family-no-missing-generic-family-keyword")],
     }

crates/biome_js_analyze/src/assists/correctness/organize_imports.rs

@@ -44,6 +44,7 @@ declare_rule! {
     pub OrganizeImports {
         version: "1.0.0",
         name: "organizeImports",
+        language: "js",
         recommended: false,
         fix_kind: FixKind::Unsafe,
     }

crates/biome_js_analyze/src/lint/a11y/no_access_key.rs

@@ -40,6 +40,7 @@ declare_rule! {
     pub NoAccessKey {
         version: "1.0.0",
         name: "noAccessKey",
+        language: "jsx",
         sources: &[RuleSource::EslintJsxA11y("no-access-key")],
         recommended: true,
         fix_kind: FixKind::Unsafe,

crates/biome_js_analyze/src/lint/a11y/no_aria_hidden_on_focusable.rs

@@ -45,6 +45,7 @@ declare_rule! {
     pub NoAriaHiddenOnFocusable {
         version: "1.4.0",
         name: "noAriaHiddenOnFocusable",
+        language: "jsx",
         sources: &[RuleSource::EslintJsxA11y("no-aria-hidden-on-focusable")],
         recommended: true,
         fix_kind: FixKind::Unsafe,

crates/biome_js_analyze/src/lint/a11y/no_aria_unsupported_elements.rs

@@ -36,6 +36,7 @@ declare_rule! {
     pub NoAriaUnsupportedElements {
         version: "1.0.0",
         name: "noAriaUnsupportedElements",
+        language: "jsx",
         sources: &[RuleSource::EslintJsxA11y("aria-unsupported-elements")],
         recommended: true,
         fix_kind: FixKind::Unsafe,

crates/biome_js_analyze/src/lint/a11y/no_autofocus.rs

@@ -60,6 +60,7 @@ declare_rule! {
     pub NoAutofocus {
         version: "1.0.0",
         name: "noAutofocus",
+        language: "jsx",
         sources: &[RuleSource::EslintJsxA11y("no-autofocus")],
         recommended: true,
         fix_kind: FixKind::Unsafe,

crates/biome_js_analyze/src/lint/a11y/no_blank_target.rs

@@ -51,6 +51,7 @@ declare_rule! {
     pub NoBlankTarget {
         version: "1.0.0",
         name: "noBlankTarget",
+        language: "jsx",
         sources: &[RuleSource::EslintReact("jsx-no-target-blank")],
         recommended: true,
         fix_kind: FixKind::Safe,

crates/biome_js_analyze/src/lint/a11y/no_distracting_elements.rs

@@ -40,6 +40,7 @@ declare_rule! {
     pub NoDistractingElements {
         version: "1.0.0",
         name: "noDistractingElements",
+        language: "jsx",
         sources: &[RuleSource::EslintJsxA11y("no-distracting-elements")],
         recommended: true,
         fix_kind: FixKind::Unsafe,

crates/biome_js_analyze/src/lint/a11y/no_header_scope.rs

@@ -40,6 +40,7 @@ declare_rule! {
     pub NoHeaderScope {
         version: "1.0.0",
         name: "noHeaderScope",
+        language: "jsx",
         sources: &[RuleSource::EslintJsxA11y("scope")],
         recommended: true,
         fix_kind: FixKind::Unsafe,

crates/biome_js_analyze/src/lint/a11y/no_interactive_element_to_noninteractive_role.rs

@@ -35,6 +35,7 @@ declare_rule! {
     pub NoInteractiveElementToNoninteractiveRole {
         version: "1.3.0",
         name: "noInteractiveElementToNoninteractiveRole",
+        language: "jsx",
         sources: &[RuleSource::EslintJsxA11y("no-interactive-element-to-noninteractive-role")],
         recommended: true,
         fix_kind: FixKind::Unsafe,

crates/biome_js_analyze/src/lint/a11y/no_noninteractive_element_to_interactive_role.rs

@@ -48,6 +48,7 @@ declare_rule! {
     pub NoNoninteractiveElementToInteractiveRole {
         version: "1.0.0",
         name: "noNoninteractiveElementToInteractiveRole",
+        language: "jsx",
         sources: &[RuleSource::EslintJsxA11y("no-noninteractive-element-to-interactive-role")],
         recommended: true,
         fix_kind: FixKind::Unsafe,

crates/biome_js_analyze/src/lint/a11y/no_noninteractive_tabindex.rs

@@ -51,6 +51,7 @@ declare_rule! {
     pub NoNoninteractiveTabindex {
         version: "1.0.0",
         name: "noNoninteractiveTabindex",
+        language: "jsx",
         sources: &[RuleSource::EslintJsxA11y("no-noninteractive-tabindex")],
         recommended: true,
         fix_kind: FixKind::Unsafe,

crates/biome_js_analyze/src/lint/a11y/no_positive_tabindex.rs

@@ -51,6 +51,7 @@ declare_rule! {
     pub NoPositiveTabindex {
         version: "1.0.0",
         name: "noPositiveTabindex",
+        language: "jsx",
         sources: &[RuleSource::EslintJsxA11y("tabindex-no-positive")],
         recommended: true,
         fix_kind: FixKind::Unsafe,

crates/biome_js_analyze/src/lint/a11y/no_redundant_alt.rs

@@ -42,6 +42,7 @@ declare_rule! {
     pub NoRedundantAlt {
         version: "1.0.0",
         name: "noRedundantAlt",
+        language: "jsx",
         sources: &[RuleSource::EslintJsxA11y("img-redundant-alt")],
         recommended: true,
     }

crates/biome_js_analyze/src/lint/a11y/no_redundant_roles.rs

@@ -46,6 +46,7 @@ declare_rule! {
     pub NoRedundantRoles {
         version: "1.0.0",
         name: "noRedundantRoles",
+        language: "jsx",
         sources: &[RuleSource::EslintJsxA11y("no-redundant-roles")],
         recommended: true,
         fix_kind: FixKind::Unsafe,

crates/biome_js_analyze/src/lint/a11y/no_svg_without_title.rs

@@ -99,6 +99,7 @@ declare_rule! {
     pub NoSvgWithoutTitle {
         version: "1.0.0",
         name: "noSvgWithoutTitle",
+        language: "jsx",
         recommended: true,
     }
 }

crates/biome_js_analyze/src/lint/a11y/use_alt_text.rs

@@ -46,6 +46,7 @@ declare_rule! {
     pub UseAltText {
         version: "1.0.0",
         name: "useAltText",
+        language: "jsx",
         sources: &[RuleSource::EslintJsxA11y("alt-text")],
         recommended: true,
     }

crates/biome_js_analyze/src/lint/a11y/use_anchor_content.rs

@@ -67,6 +67,7 @@ declare_rule! {
     pub UseAnchorContent {
         version: "1.0.0",
         name: "useAnchorContent",
+        language: "jsx",
         sources: &[RuleSource::EslintJsxA11y("anchor-has-content")],
         recommended: true,
         fix_kind: FixKind::Unsafe,

crates/biome_js_analyze/src/lint/a11y/use_aria_activedescendant_with_tabindex.rs

@@ -51,6 +51,7 @@ declare_rule! {
     pub UseAriaActivedescendantWithTabindex {
         version: "1.3.0",
         name: "useAriaActivedescendantWithTabindex",
+        language: "jsx",
         sources: &[RuleSource::EslintJsxA11y("aria-activedescendant-has-tabindex")],
         recommended: true,
         fix_kind: FixKind::Unsafe,

crates/biome_js_analyze/src/lint/a11y/use_aria_props_for_role.rs

@@ -41,6 +41,7 @@ declare_rule! {
     pub UseAriaPropsForRole {
         version: "1.0.0",
         name: "useAriaPropsForRole",
+        language: "jsx",
         sources: &[RuleSource::EslintJsxA11y("role-has-required-aria-props")],
         recommended: true,
     }

crates/biome_js_analyze/src/lint/a11y/use_button_type.rs

@@ -39,6 +39,7 @@ declare_rule! {
     pub UseButtonType {
         version: "1.0.0",
         name: "useButtonType",
+        language: "jsx",
         sources: &[RuleSource::EslintReact("button-has-type")],
         recommended: true,
     }

crates/biome_js_analyze/src/lint/a11y/use_heading_content.rs

@@ -47,6 +47,7 @@ declare_rule! {
     pub UseHeadingContent {
         version: "1.0.0",
         name: "useHeadingContent",
+        language: "jsx",
         sources: &[RuleSource::EslintJsxA11y("heading-has-content")],
         recommended: true,
     }

crates/biome_js_analyze/src/lint/a11y/use_html_lang.rs

@@ -55,6 +55,7 @@ declare_rule! {
     pub UseHtmlLang {
         version: "1.0.0",
         name: "useHtmlLang",
+        language: "jsx",
         sources: &[RuleSource::EslintJsxA11y("html-has-lang")],
         recommended: true,
     }

crates/biome_js_analyze/src/lint/a11y/use_iframe_title.rs

@@ -61,6 +61,7 @@ declare_rule! {
     pub UseIframeTitle {
         version: "1.0.0",
         name: "useIframeTitle",
+        language: "jsx",
         sources: &[RuleSource::EslintJsxA11y("iframe-has-title")],
         recommended: true,
     }