-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(analyze): add language
field to rule metadata
#2811
refactor(analyze): add language
field to rule metadata
#2811
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks to me. @Conaclos, what do you think? I'd like your opinion
CodSpeed Performance ReportMerging #2811 will not alter performanceComparing Summary
|
does the new field need to be added to codegen? |
0230679
to
4aaf470
Compare
Yeah, otherwise the macro will fail |
We should update the contribution guide to reflect the new changes |
4aaf470
to
ff18ad5
Compare
ff18ad5
to
8c6b501
Compare
I've updated the codegen and the contributing guide. |
Summary
This adds a new
language
field toRuleMetadata
so we can emit better docs for end users.closes #2801
For the sake of being comprehensive, this is the python script I used to do the codemod for all the existing rules:
Codemod
Test Plan
If it builds, it should work.