feat(biome_css_analyzer): implement noUnknownMediaFeatureName #2751
+679
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Project
Kazuhiro-Mimaki
changed the title
CodSpeed Performance ReportMerging #2751 will not alter performanceComparing Summary
|
Kazuhiro-Mimaki
force-pushed
the
Kazuhiro-Mimaki/media-feature-name-no-unknown
branch
from
e4a7b8d
to
6722366
Compare
ematipico
requested changes
May 7, 2024
crates/biome_css_analyze/src/lint/nursery/no_unknown_media_feature_name.rs
Outdated
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/no_unknown_media_feature_name.rs
Outdated
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/no_unknown_media_feature_name.rs
Outdated
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/no_unknown_media_feature_name.rs
Outdated
Show resolved
Hide resolved
| return Some(true); | ||
| } | ||
| let right = css_media_and_condition.right().ok().unwrap(); | ||
| check_any_css_media_and_combinable_condition(right) |
There was a problem hiding this comment.
I strongly suggest avoiding recursions if possible. Usually you can use loops or iterators
There was a problem hiding this comment.
I replaced recursions with loops.
Mouvedia
reviewed
May 7, 2024
Mouvedia
reviewed
May 7, 2024
Mouvedia
reviewed
May 7, 2024
Kazuhiro-Mimaki
force-pushed
the
Kazuhiro-Mimaki/media-feature-name-no-unknown
branch
2 times, most recently
from
e5ce4e0
to
51ec481
Compare
|
@Kazuhiro-Mimaki the PR has some conflicts |
Mouvedia
reviewed
May 9, 2024
Mouvedia
reviewed
May 9, 2024
Mouvedia
reviewed
May 9, 2024
Kazuhiro-Mimaki
force-pushed
the
Kazuhiro-Mimaki/media-feature-name-no-unknown
branch
2 times, most recently
from
9f180c3
to
cb86b65
Compare
Mouvedia
reviewed
May 10, 2024
ematipico
approved these changes
May 10, 2024
|
@togami2864 can you review and merge? |
togami2864
approved these changes
May 10, 2024
Kazuhiro-Mimaki
force-pushed
the
Kazuhiro-Mimaki/media-feature-name-no-unknown
branch
from
cb86b65
to
3f45256
Compare
Sec-ant
reviewed
May 10, 2024
crates/biome_css_analyze/src/lint/nursery/no_unknown_media_feature_name.rs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2626
Summary
Implements media-feature-name-no-unknown
Test Plan
Add snapshots.