Kazuhiro-Mimaki/media-feature-name-no-unknown: add example case

biomejs · May 7, 2024 · e4a7b8d · e4a7b8d
1 parent ab12668
commit e4a7b8d
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 1 deletion.
diff --git a/crates/biome_css_analyze/src/lint/nursery/no_unknown_media_feature_name.rs b/crates/biome_css_analyze/src/lint/nursery/no_unknown_media_feature_name.rs
@@ -52,6 +52,10 @@ declare_rule! {
     /// @media (400px <= width <= 700px) {}
     /// ```
     ///
+    /// ```css
+    /// @media screen and (-webkit-width > 320px) {}
+    /// ```
+    ///
     pub NoUnknownMediaFeatureName {
         version: "next",
         name: "noUnknownMediaFeatureName",

diff --git a/crates/biome_css_analyze/src/utils.rs b/crates/biome_css_analyze/src/utils.rs
@@ -136,7 +136,7 @@ pub fn is_media_feature_name(prop: &str) -> bool {
     }
     for prefix in VENDER_PREFIXES.iter() {
         for feature_name in MEDIA_FEATURE_NAMES.iter() {
-            if input == format!("{}-{}", prefix, feature_name) {
+            if input == format!("{}{}", prefix, feature_name) {
                 return true;
             }
         }

diff --git a/crates/biome_css_analyze/tests/specs/nursery/noUnknownMediaFeatureName/valid.css b/crates/biome_css_analyze/tests/specs/nursery/noUnknownMediaFeatureName/valid.css
@@ -7,6 +7,9 @@
 @media screen and (min-width: 320px) {
 }
 
+@media screen and (-webkit-min-width: 320px) {
+}
+
 @media only screen and (min-width: 320px) and (max-width: 480px) and (resolution: 150dpi) {
 }
 

diff --git a/crates/biome_css_analyze/tests/specs/nursery/noUnknownMediaFeatureName/valid.css.snap b/crates/biome_css_analyze/tests/specs/nursery/noUnknownMediaFeatureName/valid.css.snap
@@ -13,6 +13,9 @@ expression: valid.css
 @media screen and (min-width: 320px) {
 }
 
+@media screen and (-webkit-min-width: 320px) {
+}
+
 @media only screen and (min-width: 320px) and (max-width: 480px) and (resolution: 150dpi) {
 }