-
-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: migrate prettier auto endofline to LF as it's the default #2145
Conversation
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I think it’s a sensible approach. Just wondering if we should log a warning. What do you think, @ematipico ? |
Yeah I think we should log a warning at least. |
hum... as a nooob in rust i'm not really sure how should i do that... |
@eMerzh I'll give you some pointers soon :) |
Here biome/crates/biome_cli/src/execute/migrate/prettier.rs Lines 344 to 346 in 644d2f4
You'll have to read the value of console.log(markup! {
<Warn>"Warning message here"</Warn>
}); I leave the contents of the message to you |
oh ok, as simple... :) |
LGTM. Thank you! Do you mind adding a changelog entry? You can check the instructions in |
You'll also have to run |
aaarg ...omg sorry sorry 😅 |
No worries! I tweaked a few places and added a test. Hope you don't mind. |
Co-authored-by: Ze-Zheng Wu <[email protected]>
Summary
I tried to migrate from prettier, and the migration failed because of unsupported option
#2138
Test Plan
you can migrate a prettierrc like this
I KNOW that auto won't be supported, but i think it's better for the UX to continue the flow with the best option possible instead of stopping in error
feel free to close if you disagree