Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 biome migrate prettier does not recognize endOfLine auto #2138

Closed
1 task done
eMerzh opened this issue Mar 20, 2024 · 5 comments
Closed
1 task done

🐛 biome migrate prettier does not recognize endOfLine auto #2138

eMerzh opened this issue Mar 20, 2024 · 5 comments

Comments

@eMerzh
Copy link
Contributor

eMerzh commented Mar 20, 2024

Environment information

CLI:
  Version:                      1.6.1
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v21.6.2"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "npm/10.2.4"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?

  1. npx @biomejs/biome migrate prettier
  2. biome errors :
.prettierrc:10:15 deserialize ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ✖ Found an unknown value `auto`.

     8 │ 	"bracketSameLine": false,
     9 │ 	"arrowParens": "avoid",
  > 10 │ 	"endOfLine": "auto"
       │ 	             ^^^^^^
    11 │ }
    12 │

  ℹ Accepted values:

  - lf
  - crlf
  - cr

Expected result

Biome proceed :) and probably skip the endofline config?

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@ematipico
Copy link
Member

ematipico commented Mar 20, 2024

We don't support that option https://biomejs.dev/reference/configuration/#formatterlineending, and it's voluntary. I suggest you to open a discussion, or look for opened discussions around this topic

@ematipico ematipico closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
@eMerzh
Copy link
Contributor Author

eMerzh commented Mar 20, 2024

my bad, i looked for endOfLine in GH, and nothing came back ...
Would you be open to "just" make something to not define the endOfLine or something? so that the migration can proceed anyway ?

@ematipico
Copy link
Member

Sorry, I didn't understand what you're suggesting 😅

@eMerzh
Copy link
Contributor Author

eMerzh commented Mar 20, 2024

Oupsi ..
i'll try again
currently, the migrate command fails because of this option.

I totally get that you don't want to support "auto" in biome.
But i "suggest", to either ignore the "auto" value, or convert it forcibly to the preferred option.
(i would say we shouldn't leave the ending as default)

That way, the migration can proceed instead of erroring

clearer?

@eMerzh
Copy link
Contributor Author

eMerzh commented Mar 20, 2024

I'll try a pr or smth to discuss it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants