Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: noFocusedTests code fix #1864

Merged
merged 1 commit into from
Feb 19, 2024
Merged

refactor: noFocusedTests code fix #1864

merged 1 commit into from
Feb 19, 2024

Conversation

vasucp1207
Copy link
Member

Summary

Test Plan

Fix all current invalid snapshots.

Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 3cdf111
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65d34dfd64dcb7000803a858
😎 Deploy Preview https://deploy-preview-1864--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages labels Feb 19, 2024
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's an excellent addition! Thank you!

Copy link

codspeed-hq bot commented Feb 19, 2024

CodSpeed Performance Report

Merging #1864 will not alter performance

⚠️ No base runs were found

Falling back to comparing focus_test_fix (3cdf111) with main (2b88082)

Summary

✅ 93 untouched benchmarks

@vasucp1207 vasucp1207 merged commit 60dda6c into main Feb 19, 2024
22 checks passed
@vasucp1207 vasucp1207 deleted the focus_test_fix branch February 19, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants