Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lint/noFocusedTests): report fdescribe and fit #1858

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

lucasweng
Copy link
Contributor

Summary

The rule now reports fdescribe and fit.

fdescribe('foo', () => {});
fit('foo', () => {});

Test Plan

I updated the existing tests.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Feb 18, 2024
Copy link

netlify bot commented Feb 18, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 0df094f
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65d1e6c0e37ec4000806ffff
😎 Deploy Preview https://deploy-preview-1858--biomejs.netlify.app/playground
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Feb 18, 2024

CodSpeed Performance Report

Merging #1858 will not alter performance

⚠️ No base runs were found

Falling back to comparing lucasweng:lint/noFocusedTests (0df094f) with main (57fd741)

Summary

✅ 93 untouched benchmarks

@ematipico ematipico merged commit 2b88082 into biomejs:main Feb 18, 2024
17 checks passed
@lucasweng lucasweng deleted the lint/noFocusedTests branch February 18, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants