Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the linting errors due to conda-forge having a different json for… #362

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

dpryan79
Copy link
Contributor

@dpryan79 dpryan79 commented Dec 3, 2018

…mat in its repodata

This should hopefully fix some of the errors people have been hitting during linting. It turns out that the conda-forge repodata.json file has a different format than that from bioconda, having extra keys some places and fewer others. This at least allows everything to get consumed into a pandas dataframe, though I don't know if there are other downstream repercussions.

@dpryan79
Copy link
Contributor Author

dpryan79 commented Dec 3, 2018

It'll be interesting to see if this passes CI testing.

@daler
Copy link
Member

daler commented Dec 3, 2018

@dpryan79 very nice, thanks! I was simultaneously in the middle of dissecting the json diffs but you beat me to it.

Let's get this in to start clearing the backlog of lint failures . . .

@daler daler merged commit 2a62186 into bioconda:master Dec 3, 2018
daler added a commit to bioconda/bioconda-common that referenced this pull request Dec 3, 2018
for now point to last commit in bioconda/bioconda-utils#362; if this works then we can set a new version
@dpryan79 dpryan79 deleted the fix_json_parsing branch December 3, 2018 21:36
@dpryan79
Copy link
Contributor Author

dpryan79 commented Dec 3, 2018

I hope this was able to unclog the queue a bit :)

@pinin4fjords
Copy link

Thank you for the fix and re-start :-)

@bernt-matthias
Copy link

Is this another one: bioconda/bioconda-recipes#12407?

@dpryan79
Copy link
Contributor Author

dpryan79 commented Dec 4, 2018

@bernt-matthias Yup, restarted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants